Fixed country name string compare to work with unicode #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone alive on the project? |
alcohol
reviewed
Sep 7, 2022
My bad..
|
Sorry, I have not found much time to work on my open source projects for quite some time now. This change is trivial though and definitely welcome. I'll get it sorted today and get a new release out. |
|
Rebased and merged in 40ab848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I found a significant issue in the library when looking up for a country that contains non ASCII characters such as Côte d'Ivoire.
The current function to case-insensitive string compare does only work in the ASCII range but not with unicode.
More information on the issue can be found here for example: https://stackoverflow.com/questions/5473542/case-insensitive-string-comparison
I've fixed it and added a test for it.