Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aliases #76

Merged
merged 11 commits into from
Jan 23, 2023
Merged

Added aliases #76

merged 11 commits into from
Jan 23, 2023

Conversation

8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Jul 15, 2022

Thank you for a great library!

I implemented the aliases your way: #61.

@8ctopus
Copy link
Contributor Author

8ctopus commented Jan 23, 2023

Hello all, what's the status of this pull request? It's been hanging for 6 months.

@alcohol
Copy link
Owner

alcohol commented Jan 23, 2023

Can you fix the phpstan issues? Primarily the parameter types in the new aliases class.

src/ISO3166WithAliases.php Outdated Show resolved Hide resolved
src/ISO3166WithAliases.php Outdated Show resolved Hide resolved
src/ISO3166WithAliases.php Outdated Show resolved Hide resolved
src/ISO3166WithAliases.php Outdated Show resolved Hide resolved
src/ISO3166WithAliases.php Outdated Show resolved Hide resolved
@alcohol alcohol merged commit 0cf1c24 into alcohol:main Jan 23, 2023
@8ctopus
Copy link
Contributor Author

8ctopus commented Jan 23, 2023

Thank you!

@8ctopus 8ctopus deleted the aliases branch January 23, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants