Finalize docker build script #693
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| ./build.sh | ||
| --platforms ${{ env.PLATFORMS }} | ||
|
|
||
| # - name: Build Corso Binaries Locally |
There was a problem hiding this comment.
Is the plan to switch to multiplatform-binary.sh here before merge?
There was a problem hiding this comment.
Not at this time, due to the cross-platform build failures, seen here. We're unable to use that script in CI deployment, unless we connive some way around it. I should actually remove that commented section.
There was a problem hiding this comment.
It's not clear to me why this doesn't hit the same issue - we're still cross-compiling when running build in the golang container - right? Also - this discussion is not a blocker for the PR which I've approved.
There was a problem hiding this comment.
Noted. And, yeah, it isn't apparent to me either. Likewise, my local build doesn't have the same issue. Taking shots in the dark here, but I suppose the container could have some built-in emulation to help it along in some way. I'd expect github's ubuntu-latest runtime to have similar. But it's difficult to know.
Description
Modification of #660
Type of change
Please check the type of change your PR introduces:
Issue(s)
#570
Test Plan