This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
lazily fetch messages in chat #5114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
HiteshRepo
reviewed
Jan 26, 2024
| ) | ||
|
|
||
| if lastMsgPreview != nil { | ||
| preview, _, err = getChatMessageContentPreview(lastMsgPreview, noAttachments{}) |
There was a problem hiding this comment.
Suggested change
| preview, _, err = getChatMessageContentPreview(lastMsgPreview, noAttachments{}) | |
| preview, _, err = getChatMessageContentPreview(lastMsgPreview, nil) |
HiteshRepo
reviewed
Jan 26, 2024
| return str.Preview(content, 128), origSize, clues.Stack(err).OrNil() | ||
| } | ||
|
|
||
| func stripChatMessageHTML(msg models.ChatMessageable) (string, int64, error) { | ||
| func stripChatMessageHTML(msg getBodyer, atts getAttachmentser) (string, int64, error) { |
There was a problem hiding this comment.
Suggested change
| func stripChatMessageHTML(msg getBodyer, atts getAttachmentser) (string, int64, error) { | |
| func stripChatMessageHTML(msg getBodyer, atts []models.ChatMessageAttachmentable) (string, int64, error) | |
| { |
HiteshRepo
reviewed
Jan 26, 2024
| @@ -256,7 +272,7 @@ func stripChatMessageHTML(msg models.ChatMessageable) (string, int64, error) { | |||
|
|
|||
| origSize = int64(len(content)) | |||
|
|
|||
| content = replaceAttachmentMarkup(content, msg.GetAttachments()) | |||
| content = replaceAttachmentMarkup(content, atts.GetAttachments()) | |||
There was a problem hiding this comment.
Suggested change
| content = replaceAttachmentMarkup(content, atts.GetAttachments()) | |
| content = replaceAttachmentMarkup(content, atts) |
HiteshRepo
reviewed
Jan 26, 2024
| @@ -162,7 +162,7 @@ func channelMessageInfo( | |||
| modTime = lastReplyAt | |||
| } | |||
|
|
|||
| preview, contentLen, err := getChatMessageContentPreview(msg) | |||
| preview, contentLen, err := getChatMessageContentPreview(msg, msg) | |||
There was a problem hiding this comment.
Suggested change
| preview, contentLen, err := getChatMessageContentPreview(msg, msg) | |
| preview, contentLen, err := getChatMessageContentPreview(msg, msg.GetAttachments()) |
HiteshRepo
reviewed
Jan 26, 2024
| @@ -180,7 +180,7 @@ func channelMessageInfo( | |||
| var lr details.ChannelMessageInfo | |||
|
|
|||
| if lastReply != nil { | |||
| preview, contentLen, err = getChatMessageContentPreview(lastReply) | |||
| preview, contentLen, err = getChatMessageContentPreview(lastReply, lastReply) | |||
There was a problem hiding this comment.
Suggested change
| preview, contentLen, err = getChatMessageContentPreview(lastReply, lastReply) | |
| preview, contentLen, err = getChatMessageContentPreview(lastReply, lastReply.GetAttachments()) |
HiteshRepo
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Looks good.
I feel we do not need below (hence suggested changes):
// a hack for fulfilling getAttachmentser when the model doesn't
// provide GetAttachments()
type noAttachments struct{}
func (noAttachments) GetAttachments() []models.ChatMessageAttachmentable {
return []models.ChatMessageAttachmentable{}
}
type getAttachmentser interface {
GetAttachments() []models.ChatMessageAttachmentable
}
3c5dfe0
to
dfa9787
Compare
Base automatically changed from
5062-chats-backup-v0-6
to
5062-chats-backup-v0-5
January 30, 2024 02:30
Base automatically changed from
5062-chats-backup-v0-5
to
5062-chats-backup-v0-4
January 30, 2024 02:30
Base automatically changed from
5062-chats-backup-v0-4
to
5062-chats-backup-v0-3
January 30, 2024 02:30
ryanfkeepers
force-pushed
the
5062-chats-backup-v0-3
branch
from
199b692
to
93de151
Compare
Base automatically changed from
5062-chats-backup-v0-3
to
5062-chats-backup-v0
January 30, 2024 02:32
ryanfkeepers
force-pushed
the
5062-chats-backup-v0
branch
2 times, most recently
from
ba1ce0f
to
4146bff
Compare
once we're past kopia assits, the chat can download all of its messages and store them in the body uploded to kopia.
ryanfkeepers
force-pushed
the
5063-chats-backup-v0-1
branch
from
4cba773
to
316e5f0
Compare
pandeyabs
approved these changes
Jan 31, 2024
details wasn't properly listing backed up items. This fixes the details display, and contains some code clean-up that occurred along the way.
|
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once we're past kopia assits, the chat can
download all of its messages and store them in the body uploded to kopia.
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan