removes redundant details fields for lists #5050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
…sts-remove-additional
pandeyabs
approved these changes
Jan 17, 2024
| @@ -158,13 +158,13 @@ func (suite *DetailsUnitSuite) TestDetailsEntry_HeadersValues() { | |||
| ItemInfo: ItemInfo{ | |||
| SharePoint: &SharePointInfo{ | |||
| ItemType: SharePointList, | |||
| Created: now, | |||
| Modified: now, | |||
| WebURL: "https://10rqc2.sharepoint.com/sites/site-4754-small-lists/Lists/list1", | |||
There was a problem hiding this comment.
nit: can we replace this with a dummy site?
| @@ -188,13 +188,13 @@ func (suite *DetailsUnitSuite) TestDetailsEntry_HeadersValues() { | |||
| ItemInfo: ItemInfo{ | |||
| SharePoint: &SharePointInfo{ | |||
| ItemType: SharePointList, | |||
| Created: now, | |||
| Modified: now, | |||
| WebURL: "https://10rqc2.sharepoint.com/sites/site-4754-small-lists/Lists/Shared%20Documents", | |||
| WebURL string `json:"webUrl,omitempty"` | ||
| Created time.Time `json:"created,omitempty"` | ||
| Modified time.Time `json:"modified,omitempty"` | ||
| Name string `json:"name,omitempty"` |
There was a problem hiding this comment.
Given this is altering persisted state, we should merge this PR before the PR which re-enables backup for lists.
adds list time selectors #### Does this PR need a docs update or release note? - [ ] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [x] ⛔ No #### Type of change <!--- Please check the type of change your PR introduces: ---> - [x] 🌻 Feature - [ ] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Supportability/Tests - [ ] 💻 CI/Deployment - [ ] 🧹 Tech Debt/Cleanup #### Issue(s) #4754 #### Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [x] ⚡ Unit test - [x] 💚 E2E
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes redundant details fields for lists
Does this PR need a docs update or release note?
Type of change
Issue(s)
#4754
Test Plan