Lists handler #4755
Lists handler #4755
Conversation
…reate new collection instance
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
HiteshRepo
added
tech-debt
HiteshRepo
force-pushed
the
lists-handler
branch
from
cabe874
to
58e83b0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
I've only glanced over the changes. Before digging into it, I'd like to request that the PR get broken into separate parts for ease of review.
- code movement from /site/lists to /api/lists
- /api/lists.go and /api/lists_test.go additions
- /collection/site/handlers.go and /collection/site/lists_handler.go implementations
4 the rest
This will divide the PR into smaller, logical sets of changes, which will be both easier to read and easier to evaluate compared to this PR, which is acting on multiple layers at once.
| @@ -62,3 +63,228 @@ func (c Lists) PostDrive( | |||
|
|
|||
| return drive, graph.Wrap(ctx, err, "fetching created documentLibrary").OrNil() | |||
| } | |||
|
|
|||
| // SharePoint lists represent lists on a site. Inherits additional properties from | |||
There was a problem hiding this comment.
It's difficult to identify changes when code blocks get moved. Preference is to have those movements occur in a separate PR so that changes are highlighted. Could you please make a PR that separates out this movement from the rest of the changes?
| list := models.NewList() | ||
| list.SetDisplayName(&listID) | ||
|
|
||
| _, err := acl.Stable.Client().Sites().BySiteId(siteID).Lists().Post(ctx, list, nil) |
There was a problem hiding this comment.
To keep with code standards, please multi-line long func chains like this.
| _, err := acl.Stable.Client().Sites().BySiteId(siteID).Lists().Post(ctx, list, nil) | |
| _, err := acl.Stable. | |
| Client(). | |
| Sites(). | |
| BySiteId(siteID). | |
| Lists(). | |
| Post(ctx, list, nil) |
There was a problem hiding this comment.
filename suggestion: list.go. Then we can put all of the list mocks into it.
|
closing this as this PR has been bifurcated into smaller PRs |
Introduces lists backup handler, then uses it to fetch lists and its associated relationships from Lists client wrapper.
Moves code to fetch lists to Lists client wrapper.
Does this PR need a docs update or release note?
Type of change
Issue(s)
#4754
Test Plan