rename data pkg Stream to Item #3966
Conversation
ryanfkeepers
added
the
tech-debt
Current Aviator status
This PR was merged using Aviator. |
There was a problem hiding this comment.
LGTM, can we wait to merge this until after the corso extension stuff goes in though? It's probably going to create merge conflicts so would be best to let the extensions stuff go in and resolve conflicts here. I think mostly it'll be #3987 that has them but I can't be certain
| // ErrNotFound for all Fetch calls. | ||
| type NoFetchRestoreCollection struct { | ||
| Collection | ||
| FetchItemByNamer |
There was a problem hiding this comment.
nit: I know this is code movement, but this field should be removed. We're providing a function that gives this functionality, not using an embedded interface
| FetchItemByNamer |
There was a problem hiding this comment.
I'll fix that in a follow-up PR.
src/internal/data/mock/collection.go
Outdated
| DeletedFlag bool | ||
| Err error |
There was a problem hiding this comment.
could you please add a comment describing what Err and ReadErr are for?
|
Thanks @ashmrtn! @ryanfkeepers could you please hold off on this PR while the extension PRs go through? |
Yep! Not a problem. |
| @@ -0,0 +1,54 @@ | |||
| package data | |||
There was a problem hiding this comment.
Moved out of /data/collections to separate interfaces and non-interfaces (the code was getting jumbled in there). Only movement, nothing new/changed.
| // ErrNotFound for all Fetch calls. | ||
| type NoFetchRestoreCollection struct { | ||
| Collection | ||
| FetchItemByNamer |
There was a problem hiding this comment.
I'll fix that in a follow-up PR.
src/internal/data/mock/collection.go
Outdated
| DeletedFlag bool | ||
| Err error |
A Stream is a continuous transmission of data. An item is a single structure. Crossing the two definitions generates confusion.
ryanfkeepers
force-pushed
the
unify-colleciton-interfaces
branch
from
56264de
to
2aee842
Compare
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Test-Suite-Trusted |
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Test-Suite-Trusted |
|
Kudos, SonarCloud Quality Gate passed!
|
A Stream is a continuous transmission of data.
An item is a single structure. Crossing the two
definitions generates confusion.
Primarily code movement/renaming. Though there
is also some reduction/replacement of structs
where we'd made a variety of testable Item implementations
instead of re-using the generic mock.
Does this PR need a docs update or release note?
Type of change
Test Plan