Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

prevent logger flag from overriding --help #1217

Merged
merged 2 commits into from
Oct 19, 2022
Merged

prevent logger flag from overriding --help #1217

merged 2 commits into from
Oct 19, 2022

Conversation

ryanfkeepers
Copy link
Contributor

Type of change

  • 🐛 Bugfix

Issue(s)

Test Plan

  • 💪 Manual

@ryanfkeepers ryanfkeepers added bug Something isn't working mergequeue labels Oct 19, 2022
@ryanfkeepers ryanfkeepers self-assigned this Oct 19, 2022
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 19, 2022

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@ryanfkeepers ryanfkeepers temporarily deployed to Testing October 19, 2022 16:29 Inactive
@ryanfkeepers
Copy link
Contributor Author

diff across the changes

make help                                                                                                           ─╯
dir=$PWD; \
	cd ./corso/src; go run ./corso.go backup create exchange --help
Usage of seed-logger:
      --log-level string   set the log level to debug|info|warn|error (default "info")
Error: pflag: help requestedBackup M365 Exchange service data

Usage:
  corso backup create exchange --user <userId or email> | '*' [flags]

Examples:
  # Backup all Exchange data for Alice
  corso backup create exchange --user [email protected]

  # Backup only Exchange contacts for Alice and Bob
  corso backup create exchange --user [email protected],[email protected] --data contacts

  # Backup all Exchange data for all M365 users
  corso backup create exchange --user '*'

Flags:
      --user strings   Backup Exchange data by user ID; accepts '*' to select all users
      --data strings   Select one or more types of data to backup: email, contacts, or events
  -h, --help           help for exchange

Global Flags:
      --config-file string   config file location (default is $HOME/.corso.toml) (default "$HOME/.corso.toml")
      --json                 output data in JSON format
      --log-level string     set the log level to debug|info|warn|error (default "info")
      --no-stats             disable anonymous usage statistics gathering

~/go/src/github.com/alcionai ─────────────────────────────────────────────────────────────────────────── 14s 10:24:53 ─╮
❯ make help                                                                                                           ─╯
dir=$PWD; \
	cd ./corso/src; go run ./corso.go backup create exchange --help
Backup M365 Exchange service data

Usage:
  corso backup create exchange --user <userId or email> | '*' [flags]

Examples:
  # Backup all Exchange data for Alice
  corso backup create exchange --user [email protected]

  # Backup only Exchange contacts for Alice and Bob
  corso backup create exchange --user [email protected],[email protected] --data contacts

  # Backup all Exchange data for all M365 users
  corso backup create exchange --user '*'

Flags:
      --user strings   Backup Exchange data by user ID; accepts '*' to select all users
      --data strings   Select one or more types of data to backup: email, contacts, or events
  -h, --help           help for exchange

Global Flags:
      --config-file string   config file location (default is $HOME/.corso.toml) (default "$HOME/.corso.toml")
      --json                 output data in JSON format
      --log-level string     set the log level to debug|info|warn|error (default "info")
      --no-stats             disable anonymous usage statistics gathering

@ryanfkeepers ryanfkeepers temporarily deployed to Testing October 19, 2022 16:30 Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing October 19, 2022 16:30 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 19, 2022 17:30 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing October 19, 2022 17:31 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 19, 2022 17:31 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 19, 2022 17:31 Inactive
@aviator-app aviator-app bot merged commit e57aa12 into main Oct 19, 2022
@aviator-app aviator-app bot deleted the issue-763 branch October 19, 2022 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working mergequeue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants