fix: emit single /*@__PURE__*/ annotation for Rolldown 1.1+ compatibility - #374
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Install the packages built from this commit: @distilled.cloud/core bun add @distilled.cloud/core@https://pkg.distilled.cloud/core/0991ddf@distilled.cloud/aws bun add @distilled.cloud/aws@https://pkg.distilled.cloud/aws/0991ddf@distilled.cloud/axiom bun add @distilled.cloud/axiom@https://pkg.distilled.cloud/axiom/0991ddf@distilled.cloud/azure bun add @distilled.cloud/azure@https://pkg.distilled.cloud/azure/0991ddf@distilled.cloud/cloudflare bun add @distilled.cloud/cloudflare@https://pkg.distilled.cloud/cloudflare/0991ddf@distilled.cloud/coinbase bun add @distilled.cloud/coinbase@https://pkg.distilled.cloud/coinbase/0991ddf@distilled.cloud/expo-eas bun add @distilled.cloud/expo-eas@https://pkg.distilled.cloud/expo-eas/0991ddf@distilled.cloud/fly-io bun add @distilled.cloud/fly-io@https://pkg.distilled.cloud/fly-io/0991ddf@distilled.cloud/gcp bun add @distilled.cloud/gcp@https://pkg.distilled.cloud/gcp/0991ddf@distilled.cloud/kubernetes bun add @distilled.cloud/kubernetes@https://pkg.distilled.cloud/kubernetes/0991ddf@distilled.cloud/mongodb-atlas bun add @distilled.cloud/mongodb-atlas@https://pkg.distilled.cloud/mongodb-atlas/0991ddf@distilled.cloud/neon bun add @distilled.cloud/neon@https://pkg.distilled.cloud/neon/0991ddf@distilled.cloud/planetscale bun add @distilled.cloud/planetscale@https://pkg.distilled.cloud/planetscale/0991ddf@distilled.cloud/posthog bun add @distilled.cloud/posthog@https://pkg.distilled.cloud/posthog/0991ddf@distilled.cloud/prisma-postgres bun add @distilled.cloud/prisma-postgres@https://pkg.distilled.cloud/prisma-postgres/0991ddf@distilled.cloud/stripe bun add @distilled.cloud/stripe@https://pkg.distilled.cloud/stripe/0991ddf@distilled.cloud/supabase bun add @distilled.cloud/supabase@https://pkg.distilled.cloud/supabase/0991ddf@distilled.cloud/turso bun add @distilled.cloud/turso@https://pkg.distilled.cloud/turso/0991ddf@distilled.cloud/typesense bun add @distilled.cloud/typesense@https://pkg.distilled.cloud/typesense/0991ddf@distilled.cloud/workos bun add @distilled.cloud/workos@https://pkg.distilled.cloud/workos/0991ddf |
…ation Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # packages/cloudflare/src/services/d1.ts # packages/cloudflare/src/services/vectorize.ts # packages/planetscale/src/operations/listExtensions.ts # packages/planetscale/src/operations/listParameters.ts # packages/planetscale/src/operations/resetDefaultRole.ts
Co-authored-by: Cursor <cursoragent@cursor.com>
john-royal
changed the title
Mkassabov
added a commit
that referenced
this pull request
Jul 20, 2026
From v0 main (bb54823..c9a7779), everything applicable: #369 (broad AWS fan-out): full machinery delta — synthetic errors (message-matcher-carved tags, spec-schema + response-parser + generator support), legacy SigV2 for SimpleDB (signed-body request built in AwsProtocol.encode; core executes it), smithy.api#endpoint hostPrefix (label substitution + double-prefix guard; carried through core OperationConfig as endpointHostPrefix), streaming-input UNSIGNED-PAYLOAD with the service denylist, S3 Control/Glacier payload SHA-256 precompute, the new Presign module + export, union overrides / sensitive / errorHttpStatus spec-patch capabilities, and the complete aws patches dir (which includes #383's ec2 duplicate security-group synthetic errors — 16 typed variants emitted). #374: single /*@__PURE__*/ annotation (Rolldown 1.1+ treats /*#__PURE__*/ as unknown) — both generators, all services re-emitted. #379: core pagination isTerminalToken (empty-string continuation tokens end pagination instead of looping); bodyMediaType on core's HttpTrait + raw-body path in protocol-http; Vectorize insert/upsert gain their previously-unmodeled application/x-ndjson body via manual patches; D1 params retyped string[] -> unknown[] (JSON values). #368: workers createRoute error 10019 typed as RouteScriptNotFound. #380 (rulesets status_code) not ported: v1's docs-derived model already types every status_code as a number — the string bug was in v0's openapi source. Planetscale/stripe PRs N/A (no such v1 packages); the typescript-7 migration is not taken (v1 stays on tsgo). Verified: typecheck + offline wire sanity across all four families.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our generators emitted two consecutive pure annotations (
/*@__PURE__*/ /*#__PURE__*/), which Rolldown 1.1+ no longer recognizes — it drops the annotation entirely, breaking tree-shaking of SDK bundles. This changes all generators to emit only/*@__PURE__*/, which Rolldown 1.1 preserves correctly.core/scripts/generate-openapi.ts(shared by all OpenAPI-based packages), plus theaws,gcp, andcloudflaregenerators (including cloudflare'sSchema.suspendpost-processing regex that matched the double annotation)bun run generateproduces without regenerating every packagerolldown@^1.1.5to the workspace catalogbundle.test.tssmoke test to every provider that bundles the SDK fromsrcwith Rolldown and asserts it succeeds; providers with per-service entry points also bundle a representative service (aws: s3,gcp: storage-v1,cloudflare: r2,azure: storage,kubernetes: core)