Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding egyptian fractions and support for glyphs #9

Merged
merged 11 commits into from
Apr 16, 2021
Merged

Conversation

albertodev01
Copy link
Owner

Why?

In this PR I'm adding support for egyptian fractions and an improved parsing logic to also support fraction glyphs.

What?

  • Creation of the EgyptianFraction class
  • Creation of a function to encode/decode fractions from glyphs

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Documentation change (change to update documentation)

Notes

Thanks to @doppio for the contribution on glyphs conversions! 😄

Checklist

  • I have provided a description of the proposed changes.
  • I added unit tests for all relevant code.
  • I added golden tests for all UI changes.
  • I added documentation for all relevant code.

@albertodev01 albertodev01 added Documentation Improvements or additions to documentation enhancement labels Apr 12, 2021
@albertodev01 albertodev01 self-assigned this Apr 12, 2021
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #9 (29f24bc) into master (d53081d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master        #9    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7         8     +1     
  Lines          199       299   +100     
==========================================
+ Hits           199       299   +100     
Impacted Files Coverage Δ
lib/src/core.dart 100.00% <100.00%> (ø)
lib/src/egyptian.dart 100.00% <100.00%> (ø)
lib/src/extensions/fraction_string.dart 100.00% <100.00%> (ø)
lib/src/extensions/mixed_string.dart 100.00% <100.00%> (ø)
lib/src/mixed.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53081d...29f24bc. Read the comment docs.

@albertodev01
Copy link
Owner Author

albertodev01 commented Apr 16, 2021

@doppio done! Your PR is part of the 3.0.0 version that will be published in a moment 😄

@albertodev01 albertodev01 merged commit 456e342 into master Apr 16, 2021
@albertodev01 albertodev01 deleted the develop branch April 16, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants