Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new 'MixedFraction.fromDouble' constructor #19

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Conversation

albertodev01
Copy link
Owner

Why?

An issue (#18) pointed out the absence of a factory constructor.

What?

I have added the MixedFraction.fromDouble factory constructor to MixedFraction and tested it.

Types of Changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have provided a description of the proposed changes.
  • I added unit tests for all relevant code.
  • I added golden tests for all UI changes.
  • I added documentation for all relevant code.

@albertodev01 albertodev01 self-assigned this Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #19 (bb25d3d) into master (05e92d9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          322       325    +3     
=========================================
+ Hits           322       325    +3     
Impacted Files Coverage Δ
lib/src/types/mixed.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e92d9...bb25d3d. Read the comment docs.

@albertodev01 albertodev01 merged commit 4cf2db9 into master Jul 20, 2022
@albertodev01 albertodev01 deleted the develop branch July 20, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant