Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added stricter linter rules #11

Merged
merged 2 commits into from
Sep 10, 2021
Merged

chore: Added stricter linter rules #11

merged 2 commits into from
Sep 10, 2021

Conversation

albertodev01
Copy link
Owner

Why?

With the new Dart 2.14 release, there is a new recommended set of lints to apply. The package also needs stricter lint rules

What?

I have added the Dart's official lints package and the dart_code_metrics one as well

Types of Changes

  • New feature (non-breaking change which adds functionality)

Notes

No new features added

Checklist

  • I have provided a description of the proposed changes.
  • I added unit tests for all relevant code.
  • I added golden tests for all UI changes.
  • I added documentation for all relevant code.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #11 (c1b0380) into master (c73279a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          305       305           
=========================================
  Hits           305       305           
Impacted Files Coverage Δ
lib/src/extensions/fraction_string.dart 100.00% <ø> (ø)
lib/src/extensions/mixed_string.dart 100.00% <ø> (ø)
lib/src/core.dart 100.00% <100.00%> (ø)
lib/src/egyptian.dart 100.00% <100.00%> (ø)
lib/src/mixed.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73279a...c1b0380. Read the comment docs.

@albertodev01 albertodev01 merged commit 45271ca into master Sep 10, 2021
@albertodev01 albertodev01 deleted the develop branch September 10, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant