Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unix sockets #75

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Unix sockets #75

merged 3 commits into from
Mar 18, 2024

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Mar 4, 2024 •
edited
Loading

Platform specific stuff is best avoided but Unix sockets should be used when they are available.

I've only tested on Linux.

alaviss
alaviss reviewed Mar 9, 2024
View reviewed changes
Copy link
Owner

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

There are a couple small adjustments that I would like to see, but everything else looks great.

src/sys/private/sockets_posix.nim Outdated Show resolved Hide resolved
src/sys/private/sockets_posix.nim Outdated Show resolved Hide resolved
src/sys/sockets.nim Outdated Show resolved Hide resolved
src/sys/private/sockets_posix.nim Outdated Show resolved Hide resolved
src/sys/private/sockets_posix.nim Outdated Show resolved Hide resolved
src/sys/sockets.nim Outdated Show resolved Hide resolved
tests/sockets/tsockets.nim Outdated Show resolved Hide resolved
tests/sockets/tsockets.nim Outdated Show resolved Hide resolved
@ehmry ehmry requested a review from alaviss March 11, 2024 11:48
alaviss
alaviss approved these changes Mar 13, 2024
View reviewed changes
Copy link
Owner

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to make this compile on Windows and we're gold

src/sys/private/sockets_windows.nim Outdated Show resolved Hide resolved
src/sys/sockets.nim Outdated Show resolved Hide resolved
tests/sockets/tsockets.nim Outdated Show resolved Hide resolved
@ehmry ehmry requested a review from alaviss March 15, 2024 15:32
@alaviss alaviss merged commit 0e0ea23 into alaviss:master Mar 18, 2024
15 checks passed
@ehmry ehmry deleted the unix-sockets branch March 18, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaviss alaviss Awaiting requested review from alaviss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmry @alaviss