Add coverage for AWS SQS #1988

mtp1376 · 2023-02-14T15:55:22Z

Also:

Add normalizePolicy function and use it in policiesAreSame function
Use strongly-typed IAM policies across the codebase

test/modules/aws-sqs-integration.ts

src/modules/aws_sdk/index.ts

src/modules/interfaces.ts

src/services/aws_macros.ts

test/modules/aws-acm-import-integration.ts

github-actions · 2023-02-16T13:24:32Z

⏳ All modules installed in: 40.864969336 seconds ⌛️
⏳ All modules uninstalled in: .879565110 seconds ⌛️

src/modules/aws_sqs/entity/queue.ts

dfellis · 2023-02-16T14:21:18Z

src/modules/aws_sqs/sql/after_install.sql

+    IF (NEW.name NOT LIKE '%.fifo') AND (NEW.fifo_queue) THEN
+        RAISE EXCEPTION 'The name of a fifo queue should end with .fifo';
+    END IF;
+    IF (NEW.name LIKE '%.fifo') AND (NOT NEW.fifo_queue) THEN
+        RAISE EXCEPTION 'Non-fifo queue name should not end with .fifo';
+    END IF;


I understand why this is here, but wtf AWS. I am tempted to say "just auto add the .fifo prefix when needed and only ban having it explicitly in here" but that could cause confusion for other modules needing to reference this name so...

AWS stuff give me 2 wtfs/hour in average. The listQueues API has a 40 seconds cache and doesn't get invalidated even in case a new queue is created. 🤦🏻

Also, about FifoQueue field the documentation says it's "true" | "false", but if you send false string it will complain and the field should be omitted.

And the issue is there since 2020.

mtp1376 · 2023-02-17T13:28:25Z

CodeBuild project tests are failing with this error:

[Container] 2023/02/17 13:08:53 Running command docker pull ubuntu:latest
39 | Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
40

github-actions · 2023-02-17T16:50:49Z

⏳ All modules installed in: 46.337581369 seconds ⌛️
⏳ All modules uninstalled in: .882825423 seconds ⌛️

github-actions · 2023-02-17T17:29:23Z

⏳ All modules installed in: 41.274496447 seconds ⌛️
⏳ All modules uninstalled in: .834737517 seconds ⌛️

dfellis · 2023-02-17T20:31:47Z

Pretty consistent failure. Looks like a diffing bug https://github.com/iasql/iasql/actions/runs/4206072004/jobs/7301643249#step:9:48173

Signed-off-by: Mohammad Teimori Pabandi <[email protected]>

* Add `normalizePolicy` method and use it in `policiesAreSame` Signed-off-by: Mohammad Teimori Pabandi <[email protected]> * Fix styling --------- Signed-off-by: Mohammad Teimori Pabandi <[email protected]>

Co-authored-by: David Ellis <[email protected]>

Signed-off-by: Mohammad Teimori Pabandi <[email protected]>

github-actions · 2023-02-20T13:10:04Z

⏳ All modules installed in: 39.955264374 seconds ⌛️
⏳ All modules uninstalled in: .887604424 seconds ⌛️

Signed-off-by: Mohammad Teimori Pabandi <[email protected]>

github-actions · 2023-02-20T13:50:20Z

⏳ All modules installed in: 44.357704971 seconds ⌛️
⏳ All modules uninstalled in: .973470664 seconds ⌛️

mtp1376 linked an issue Feb 14, 2023 that may be closed by this pull request

aws_sqs support #1969

Closed

mtp1376 marked this pull request as ready for review February 15, 2023 16:09

mtp1376 requested review from yrobla, aguillenv, dfellis and depombo and removed request for yrobla February 15, 2023 16:09

yrobla suggested changes Feb 15, 2023

View reviewed changes

test/modules/aws-sqs-integration.ts Show resolved Hide resolved

mtp1376 requested a review from yrobla February 15, 2023 17:13