chore: trigger cpp validation#9
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
This PR is a chore to trigger C++ validation by removing the entire XSEPlugin.cpp file.
- Removed XSEPlugin.cpp, which contained plugin initialization and logging setup.
- The change may require updates in build configurations or dependency references.
Comments suppressed due to low confidence (1)
src/XSEPlugin.cpp:1
- Ensure that the removal of XSEPlugin.cpp is intentional and verify that any build or configuration references are updated accordingly.
Entire file removal
|
✅ A pre-release build is available for this PR: |
6 tasks
alandtse
added a commit
that referenced
this pull request
May 23, 2026
Reintroduce Light Limit Fix contact shadows for clustered point lights, reversing the maintainability-driven removal in 347cb55. That removal cited no defect, and the shader call site was already commented out at the time of deletion, so this is reviving a dormant feature rather than introducing new behaviour. Adapted from the original implementation: - LightLimitFix::ContactShadows() raymarch helper restored verbatim - EnableContactShadows toggle re-added to LightLimitFix Settings and the SharedData::LightLimitFixSettings cbuffer - Shadows section restored in the LLF settings UI (session-only, matching the current LLF settings-persistence stance) - Wired into Lighting.hlsl as a multiplier on pointLightShadow, which the upstream DirectContext/EvaluateLighting refactor funnels into both the PBR and legacy paths uniformly VR jitter stabilization (concept from ParticleTroned's 8e615ea): - Hoist the contact-shadow noise sample out of the per-light loop and compute it once per pixel from (uv * eye-buffer dim) in VR or raw pixel position in flat. Using raw pixel coords in VR makes each eye sample a different noise pattern at the same world position, which reads as flicker on contact-shadow recipients. - New helpers LightLimitFix::GetContactShadowScreenDim() and GetContactShadowNoiseCoord() centralise the stereo-aware sampling. Bumps Light Limit Fix feature version to 3-1-0 (minor: new persisted cbuffer field, new user-facing toggle). Original contact-shadow implementation by jiayev (merged via #9 prior to the 347cb55 removal). VR jitter analysis and fix from ParticleTroned's fork. Co-Authored-By: jiayev <jiayev1@gmail.com> Co-Authored-By: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
alandtse
added a commit
that referenced
this pull request
May 24, 2026
Reintroduce Light Limit Fix contact shadows for clustered point lights, reversing the maintainability-driven removal in 347cb55. That removal cited no defect, and the shader call site was already commented out at the time of deletion, so this is reviving a dormant feature rather than introducing new behaviour. Adapted from the original implementation: - LightLimitFix::ContactShadows() raymarch helper restored verbatim - EnableContactShadows toggle re-added to LightLimitFix Settings and the SharedData::LightLimitFixSettings cbuffer - Shadows section restored in the LLF settings UI (session-only, matching the current LLF settings-persistence stance) - Wired into Lighting.hlsl as a multiplier on pointLightShadow, which the upstream DirectContext/EvaluateLighting refactor funnels into both the PBR and legacy paths uniformly VR jitter stabilization (concept from ParticleTroned's 8e615ea): - Hoist the contact-shadow noise sample out of the per-light loop and compute it once per pixel from (uv * eye-buffer dim) in VR or raw pixel position in flat. Using raw pixel coords in VR makes each eye sample a different noise pattern at the same world position, which reads as flicker on contact-shadow recipients. - New helpers LightLimitFix::GetContactShadowScreenDim() and GetContactShadowNoiseCoord() centralise the stereo-aware sampling. Bumps Light Limit Fix feature version to 3-1-0 (minor: new persisted cbuffer field, new user-facing toggle). Original contact-shadow implementation by jiayev (merged via #9 prior to the 347cb55 removal). VR jitter analysis and fix from ParticleTroned's fork. Co-Authored-By: jiayev <jiayev1@gmail.com> Co-Authored-By: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
alandtse
added a commit
that referenced
this pull request
May 24, 2026
Reintroduce Light Limit Fix contact shadows for clustered point lights, reversing the maintainability-driven removal in 347cb55. That removal cited no defect, and the shader call site was already commented out at the time of deletion, so this is reviving a dormant feature rather than introducing new behaviour. Adapted from the original implementation: - LightLimitFix::ContactShadows() raymarch helper restored verbatim - EnableContactShadows toggle re-added to LightLimitFix Settings and the SharedData::LightLimitFixSettings cbuffer - Shadows section restored in the LLF settings UI (session-only, matching the current LLF settings-persistence stance) - Wired into Lighting.hlsl as a multiplier on pointLightShadow, which the upstream DirectContext/EvaluateLighting refactor funnels into both the PBR and legacy paths uniformly VR jitter stabilization (concept from ParticleTroned's 8e615ea): - Hoist the contact-shadow noise sample out of the per-light loop and compute it once per pixel from (uv * eye-buffer dim) in VR or raw pixel position in flat. Using raw pixel coords in VR makes each eye sample a different noise pattern at the same world position, which reads as flicker on contact-shadow recipients. - New helpers LightLimitFix::GetContactShadowScreenDim() and GetContactShadowNoiseCoord() centralise the stereo-aware sampling. Bumps Light Limit Fix feature version to 3-1-0 (minor: new persisted cbuffer field, new user-facing toggle). Original contact-shadow implementation by jiayev (merged via #9 prior to the 347cb55 removal). VR jitter analysis and fix from ParticleTroned's fork. Co-Authored-By: jiayev <jiayev1@gmail.com> Co-Authored-By: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
alandtse
added a commit
that referenced
this pull request
May 24, 2026
Reintroduce Light Limit Fix contact shadows for clustered point lights, reversing the maintainability-driven removal in 347cb55. That removal cited no defect, and the shader call site was already commented out at the time of deletion, so this is reviving a dormant feature rather than introducing new behaviour. Adapted from the original implementation: - LightLimitFix::ContactShadows() raymarch helper restored verbatim - EnableContactShadows toggle re-added to LightLimitFix Settings and the SharedData::LightLimitFixSettings cbuffer - Shadows section restored in the LLF settings UI (session-only, matching the current LLF settings-persistence stance) - Wired into Lighting.hlsl as a multiplier on pointLightShadow, which the upstream DirectContext/EvaluateLighting refactor funnels into both the PBR and legacy paths uniformly VR jitter stabilization (concept from ParticleTroned's 8e615ea): - Hoist the contact-shadow noise sample out of the per-light loop and compute it once per pixel from (uv * eye-buffer dim) in VR or raw pixel position in flat. Using raw pixel coords in VR makes each eye sample a different noise pattern at the same world position, which reads as flicker on contact-shadow recipients. - New helpers LightLimitFix::GetContactShadowScreenDim() and GetContactShadowNoiseCoord() centralise the stereo-aware sampling. Bumps Light Limit Fix feature version to 3-1-0 (minor: new persisted cbuffer field, new user-facing toggle). Original contact-shadow implementation by jiayev (merged via #9 prior to the 347cb55 removal). VR jitter analysis and fix from ParticleTroned's fork. Co-Authored-By: jiayev <jiayev1@gmail.com> Co-Authored-By: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
alandtse
added a commit
that referenced
this pull request
May 24, 2026
Reintroduce Light Limit Fix contact shadows for clustered point lights, reversing the maintainability-driven removal in 347cb55. That removal cited no defect, and the shader call site was already commented out at the time of deletion, so this is reviving a dormant feature rather than introducing new behaviour. Adapted from the original implementation: - LightLimitFix::ContactShadows() raymarch helper restored verbatim - EnableContactShadows toggle re-added to LightLimitFix Settings and the SharedData::LightLimitFixSettings cbuffer - Shadows section restored in the LLF settings UI (session-only, matching the current LLF settings-persistence stance) - Wired into Lighting.hlsl as a multiplier on pointLightShadow, which the upstream DirectContext/EvaluateLighting refactor funnels into both the PBR and legacy paths uniformly VR jitter stabilization (concept from ParticleTroned's 8e615ea): - Hoist the contact-shadow noise sample out of the per-light loop and compute it once per pixel from (uv * eye-buffer dim) in VR or raw pixel position in flat. Using raw pixel coords in VR makes each eye sample a different noise pattern at the same world position, which reads as flicker on contact-shadow recipients. - New helpers LightLimitFix::GetContactShadowScreenDim() and GetContactShadowNoiseCoord() centralise the stereo-aware sampling. Bumps Light Limit Fix feature version to 3-1-0 (minor: new persisted cbuffer field, new user-facing toggle). Original contact-shadow implementation by jiayev (merged via #9 prior to the 347cb55 removal). VR jitter analysis and fix from ParticleTroned's fork. Co-Authored-By: jiayev <jiayev1@gmail.com> Co-Authored-By: ParticleTroned <248299730+ParticleTroned@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.