Skip to content

feat(llf): restore JSON-scaled Particle Lights #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 5 commits into from
May 30, 2026
Merged

feat(llf): restore JSON-scaled Particle Lights #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12de972
feat(llf): restore JSON-scaled Particle Lights
alandtse May 29, 2026
6c09794
refactor(llf): clarify and reorganize particle-light settings UI
alandtse May 29, 2026
13b3cfa
build(deps): bump CommonLibVR to 4.19.0, adopt emittanceColor
alandtse May 29, 2026
ba00d89
refactor(llf): make ParticleLights a feature member, not a global
alandtse May 29, 2026
5113746
fix(llf): populate EnableContactShadows; clear particle cache on earl…
alandtse May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extern/CommonLibSSE-NG
Open in desktop
Submodule CommonLibSSE-NG updated 5 files
+6 −0 CHANGELOG.md
+1 −1 CMakeLists.txt
+2 −3 include/RE/B/BSEffectShaderProperty.h
+24 −24 include/RE/B/BSShadowLight.h
+1 −1 vcpkg.json
1 change: 1 addition & 0 deletions features/Light Limit Fix/Shaders/LightLimitFix/Common.hlsli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace LightFlags
static const uint Disabled = (1 << 9);
static const uint InverseSquare = (1 << 10);
static const uint Linear = (1 << 11);
static const uint Particle = (1 << 12);
}

struct ClusterAABB
Expand Down
3 changes: 2 additions & 1 deletion package/Shaders/Common/SharedData.hlsli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ namespace SharedData
// Debug (last)
uint EnableLightsVisualisation;
uint LightsVisualisationMode;
uint2 pad0;
uint EnableParticleContactShadows;
uint pad0;
};

struct WetnessEffectsSettings
Expand Down
9 changes: 8 additions & 1 deletion package/Shaders/Lighting.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,8 +2801,15 @@ PS_OUTPUT main(PS_INPUT input, bool frontFace : SV_IsFrontFace)
# endif
}

// Particle lights carry both Simple and Particle bits. Simple-only lights are
// clustered fallbacks (no real emitter) and never trace; particle lights trace
// only when the user opted in via EnableParticleContactShadows.
const bool isParticleLight = (light.lightFlags & LightLimitFix::LightFlags::Particle) != 0;
const bool canShadow = isParticleLight ?
SharedData::lightLimitFixSettings.EnableParticleContactShadows :
!(light.lightFlags & LightLimitFix::LightFlags::Simple);
[branch] if (
!(light.lightFlags & LightLimitFix::LightFlags::Simple) &&
canShadow &&
shadowComponent != 0.0 &&
lightAngle > 0.0 &&
passesIntensityGate)
Expand Down
Loading
Loading