refactor(menu): regroup Advanced tabs by purpose

[alandtse]

Summary

• Regroup the Advanced menu's tabs from audience-based (Developer / Logging / Shader Debug / Disable at Boot / Testing) to four alphabetical, purpose-based tabs: Shaders, Diagnostics, Disable at Boot, Testing.
• Drop two redundant nested headings: CollapsingHeader("Testing") inside the Testing tab, and CollapsingHeader("Active Shaders") inside the Shader Blocking panel.
• Move "Skip Clear Cache Dialogue" from Shaders to Behavior (UI behavior, not a shader setting); update the docs path in docs/development/vscode-setup.md accordingly.

New tab contents

Tab	Sections
Shaders	Compile Flags · Threading · Cache & File Watcher · Replace Original Shaders · Statistics
Diagnostics	Logging · Runtime Debug · Shader Blocking (dev-mode only)
Disable at Boot	unchanged
Testing	A/B harness + dev-mode test scaffolding

No functional change to shader compilation, blocking, A/B, or boot toggles — purely reorganization plus the dedupe.

Test plan

• Build ALL preset, launch in-game, open Settings → Advanced
• Verify all four tabs render; no orphan TableNextColumn or ImGui assertion warnings in log
• Toggle Developer Mode and confirm dev-only sections (Shader Blocking panel, Replace shaders V/P/C, FeatureIssues testing UI) appear/disappear
• Open Testing tab and confirm the "Feature Issue Testing" section renders inline (no extra "Testing" expander above it)
• Open Diagnostics → Shader Blocking → Active Shaders and confirm the table renders inline under a section header (no extra collapsing header)
• Confirm "Skip Clear Cache Dialogue" appears under Settings → Behavior, not under Shaders

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation

  • Updated VSCode setup guide to reference the correct in-game path for shader file watcher settings: "Shaders → Cache & File Watcher".

• Refactor

  • Reorganized Advanced Settings with a new Shaders tab (compile flags, threading, cache controls, replacement toggles, statistics).
  • Moved "Skip Clear Cache Confirmation" from Shaders to Behavior tab.
  • Streamlined developer-mode Feature Issue Testing UI and adjusted button wording to "Create Test INIs".

[coderabbitai]

Warning

Rate limit exceeded

@alandtse has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 27 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4fd05351-4eb2-4f3f-931a-b894ac33b651

📥 Commits

Reviewing files that changed from the base of the PR and between 1756a79 and d1ca935.

📒 Files selected for processing (1)

• src/Menu/AdvancedSettingsRenderer.cpp

📝 Walkthrough

Walkthrough

This PR reorganizes the Advanced Settings UI by introducing a dedicated Shaders tab, refactoring shader controls into component methods, restructuring Diagnostics with separate logging and runtime debug sections, adding shader compilation statistics, expanding the Testing section, and relocating the cache confirmation checkbox from Shaders to Behavior tab.

Changes

Advanced Settings UI Reorganization

Layer / File(s)	Summary
Tab Architecture and Private API Reorganization src/Menu/AdvancedSettingsRenderer.cpp, src/Menu/AdvancedSettingsRenderer.h	The tab bar layout is restructured to remove Developer/logging-style tabs and introduce a dedicated Shaders tab with reordered sections. The private method API is refactored: old section renderers are replaced with new top-level RenderShadersSection and RenderDiagnosticsSection plus multiple helper renderers.
Shaders Section with Compile, Threading, and Cache Controls src/Menu/AdvancedSettingsRenderer.cpp	New RenderShadersSection assembles shader UI: RenderShaderCompileFlags adds half-precision and avoid-flow-control toggles (cache-clearing on change), RenderShaderThreading handles threading controls, and shader cache controls include an Enable File Watcher option.
Shader Replacement, Compile Statistics, and Diagnostics src/Menu/AdvancedSettingsRenderer.cpp	Adds RenderShaderReplacementTable and RenderShaderCompileStatistics (compiler stats, lazy parallelism/work metrics, top slowest shaders). Introduces RenderDiagnosticsSection with RenderLoggingControls and RenderRuntimeDebugControls, and reorganizes the shader blocking/active-shaders UI.
Disable at Boot and Testing Section src/Menu/AdvancedSettingsRenderer.cpp	Refactors Disable at Boot to invoke a provided callback and expands RenderTestingSection to always draw A/B testing UI and add developer-mode testing scaffolding including a Test Conditions button that runs console commands when prerequisites exist.
Settings Tab Migration, FeatureIssues, and Docs src/Menu/SettingsTabRenderer.cpp, src/FeatureIssues.cpp, docs/development/vscode-setup.md	Moves the "Skip Clear Cache Confirmation" checkbox from the Shaders tab to the Behavior tab. Refactors FeatureIssues developer testing UI rendering (no behavioral change). Updates VSCode setup docs to reference "Shaders → Cache & File Watcher → Enable File Watcher".

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

I’m a rabbit in the codewood, nibbling tabs with glee,
I reordered shaders, tidy as can be.
Flags and stats now hop in line,
Tests and docs all look divine,
A tiny patch — a merry tweak! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately and concisely describes the main objective of reorganizing the Advanced settings menu tabs from audience-based grouping to purpose-based grouping.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/determined-wescoff-f9148e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/Menu/AdvancedSettingsRenderer.cpp`:
- Around line 409-412: The ImGui::SameLine() call is misplaced inside the
ImGui::Combo change branch and is dead code; move the layout call out of the
conditional or remove it so it's used only for arranging widgets, and ensure
ImGui::Combo("Log Level", &item_current, items, IM_ARRAYSIZE(items)) and
globals::state->SetLogLevel(static_cast<spdlog::level::level_enum>(item_current))
remain intact while deleting or relocating ImGui::SameLine() so it is not
executed only when SetLogLevel runs.
- Line 268: Replace the unsafe ImGui::Text(std::format(...).c_str()) call so the
result string isn't treated as a format string: either pass the formatted string
to ImGui::TextUnformatted(...) or call ImGui::Text("%s",
shaderCache->GetShaderStatsString().c_str()); update the usage around
ImGui::Text, std::format and shaderCache->GetShaderStatsString() in
AdvancedSettingsRenderer (the line creating the "Shader Compiler" text)
accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f09c8d14-5240-47f1-8563-935bb53160af

📥 Commits

Reviewing files that changed from the base of the PR and between fd20066 and ffb86ce.

📒 Files selected for processing (5)

• docs/development/vscode-setup.md
• src/FeatureIssues.cpp
• src/Menu/AdvancedSettingsRenderer.cpp
• src/Menu/AdvancedSettingsRenderer.h
• src/Menu/SettingsTabRenderer.cpp

[Copilot]

Pull request overview

Refactors the in-game Settings → Advanced UI to group options by purpose rather than by audience, while moving one UI behavior toggle to a more appropriate tab and updating developer documentation accordingly.

Changes:

• Reorganized Advanced settings into purpose-based tabs (Shaders / Diagnostics / Disable at Boot / Testing) and split large sections into helper render functions.
• Moved “Skip Clear Cache …” from shader-related settings to UI Behavior in the Behavior tab.
• Updated VSCode setup documentation to match the new Advanced menu path for the built-in shader file watcher.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Menu/SettingsTabRenderer.cpp	Moves the “Skip Clear Cache …” checkbox into the Behavior tab UI behavior section.
src/Menu/AdvancedSettingsRenderer.h	Updates the Advanced settings renderer interface to new purpose-based sections + helper methods.
src/Menu/AdvancedSettingsRenderer.cpp	Implements the new Advanced tab layout and refactors rendering into purpose-based sections.
src/FeatureIssues.cpp	Removes the extra nested “Testing” collapsing header so the testing UI renders inline.
docs/development/vscode-setup.md	Updates documentation to the new Advanced → Shaders → Cache & File Watcher path.

Comments suppressed due to low confidence (2)

src/Menu/AdvancedSettingsRenderer.cpp:171

• The SliderInt max uses std::thread::hardware_concurrency() directly. Per the standard this can return 0, which would make the slider range invalid (min=1 > max=0) and can trigger ImGui assertions. Consider clamping the max to at least 1 (e.g., use std::max(1u, std::thread::hardware_concurrency()) or a small helper) for both thread sliders.

	ImGui::SliderInt("Compiler Threads", &shaderCache->compilationThreadCount, 1, static_cast<int32_t>(std::thread::hardware_concurrency()));
	if (auto _tt = Util::HoverTooltipWrapper()) {
		ImGui::Text(
			"Number of threads used to compile shaders at startup. "
			"Defaults to all logical cores minus one for OS headroom (E-cores included). "
			"Higher values finish compilation faster but may make the system less responsive.");
	}
	ImGui::SliderInt("Background Compiler Threads", &shaderCache->backgroundCompilationThreadCount, 1, static_cast<int32_t>(std::thread::hardware_concurrency()));
	if (auto _tt = Util::HoverTooltipWrapper()) {

src/Menu/AdvancedSettingsRenderer.cpp:114

• State::SetDefines() does parsing + logging; calling it on every ImGui::InputText change will re-parse and potentially spam debug logs on every keystroke. Since you already apply/clear-cache on IsItemDeactivatedAfterEdit() / Enter, consider only calling SetDefines in that commit path (or throttle) to reduce per-keystroke work while typing.

	// Shader Defines input
	auto& shaderDefines = globals::state->shaderDefinesString;
	if (ImGui::InputText("Shader Defines", &shaderDefines)) {
		globals::state->SetDefines(shaderDefines);
	}
	if (ImGui::IsItemDeactivatedAfterEdit() || (ImGui::IsItemActive() &&
												   (ImGui::IsKeyPressed(ImGuiKey_Enter) ||
													   ImGui::IsKeyPressed(ImGuiKey_KeypadEnter)))) {
		globals::state->SetDefines(shaderDefines);
		shaderCache->Clear();
	}

[github-actions]

✅ A pre-release build is available for this PR:
Download

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/Menu/AdvancedSettingsRenderer.cpp:171

• std::thread::hardware_concurrency() is permitted to return 0. Passing that directly as the slider max can produce an invalid range (min=1, max=0) and can also undermine clamping logic elsewhere. Consider computing a safe max like max(1u, hardware_concurrency()) (and reusing it for both sliders).

	Util::DrawSectionHeader("Threading");

	ImGui::SliderInt("Compiler Threads", &shaderCache->compilationThreadCount, 1, static_cast<int32_t>(std::thread::hardware_concurrency()));
	if (auto _tt = Util::HoverTooltipWrapper()) {
		ImGui::Text(
			"Number of threads used to compile shaders at startup. "
			"Defaults to all logical cores minus one for OS headroom (E-cores included). "
			"Higher values finish compilation faster but may make the system less responsive.");
	}
	ImGui::SliderInt("Background Compiler Threads", &shaderCache->backgroundCompilationThreadCount, 1, static_cast<int32_t>(std::thread::hardware_concurrency()));
	if (auto _tt = Util::HoverTooltipWrapper()) {

src/FeatureIssues.cpp:1527

• Tooltip text refers to 'Create Test Inis' but elsewhere uses the acronym 'INI'. Consider using 'Create Test INIs' for consistency.

					ImGui::Text(
						"Removes all test INI files and restores any modified INI files to their original state.\n"
						"This undoes all changes made by 'Create Test Inis'.\n"
						"Restart CS after restoring to see normal operation.");

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.