feat(tracy): bump to upstream master snapshot#26
Conversation
Pin tracy to wolfpld/tracy@1f1738c2 (post-0.13.1) so we pick up features merged after the 0.13.1 tag. Two follow-on changes were required to keep the integration working: * Upstream changed TRACY_ENABLE's default from ON to OFF in this range, so vcpkg was producing a stub TracyClient.lib (~50 KB) with no TRACY_ENABLE in its INTERFACE_COMPILE_DEFINITIONS. The build linked, but every ZoneScoped expanded to a no-op and the profiler could not see the game. Pass -DTRACY_ENABLE=ON in the port's CMake options so the real client (~2.4 MB) is built and the macro is exported to consumers via the Tracy::TracyClient imported target. * Request the on-demand feature in the project's vcpkg manifest so the client only emits data while a profiler is connected, keeping runtime overhead at ~0 when nothing is attached. Version-string bumped to 0.13.3-1f1738c2-enable to invalidate vcpkg's binary cache so the new options take effect. Verified end-to-end: rebuilt CommunityShaders.dll, launched SE, tracy-profiler discovered and connected to the client, and zones across Deferred, Skylighting, Upscaling, SSGI, and per-feature hooks reported real timings (median 16.7 ms / 60 Hz, GPU 26% and CPU 21% of frame budget). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable suggestions for changed features. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughUpdates Tracy port: new Git REF and SHA512, adds ChangesTracy Profiler Dependency Upgrade
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.21.0)OpenGrep fatal error (exit code 2): [00.13][ERROR]: Error: exception Unix_error: No such file or directory stat cmake/ports/tracy/vcpkg.json 🔧 Checkov (3.2.529)vcpkg.json2026-05-20 03:38:07,281 [MainThread ] [ERROR] Template file not found: vcpkg.json ... [truncated 2530 characters] ... 70 [MainThread ] [WARNI] Secret scanning: could not process file vcpkg.json cmake/ports/tracy/vcpkg.json2026-05-20 03:38:07,284 [MainThread ] [ERROR] Template file not found: cmake/ports/tracy/vcpkg.json ... [truncated 2692 characters] ... anning: could not process file cmake/ports/tracy/vcpkg.json Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ A pre-release build is available for this PR: |
Move the vcpkg pin from 1f1738c2 to wolfpld/tracy@14a1a322 (upstream master HEAD) to pick up 12 newer commits, notably upstream PR community-shaders#1362 which adds the save_trace MCP tool plus parent-callstack and JSON-callstack improvements. Keeps the client baked into the game in protocol/source sync with locally built tracy-profiler and the MCP server. The build-tools.patch context is unchanged at the new commit (tail of CMakeLists.txt, head of cmake/server.cmake and cmake/vendor.cmake all match), so the patch still applies cleanly with no edits. Version-string normalized to 0.13.3-14a1a322 (dropped the ad-hoc "-enable" suffix; the commit hash already gives vcpkg a unique cache key). Verified: tracy[core,crash-handler,on-demand]@0.13.3-14a1a322 installs cleanly, TracyClient.lib stays ~2.4 MB with TRACY_ENABLE;TRACY_ON_DEMAND on the imported target's INTERFACE_COMPILE_DEFINITIONS, CommunityShaders.dll rebuilds and deploys. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Empty commit to trigger CodeQL on this PR. The default-setup CodeQL workflow only fires on synchronize events, not reopened, so a push is required to gate the PR on the new code scan. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 participant
Summary
wolfpld/tracy@1f1738c2(post-0.13.1) to pick up features merged after the 0.13.1 tag.-DTRACY_ENABLE=ONin the vcpkg port options — upstream changed this option's default fromONtoOFFafter 0.13.1, which silently produced a stubTracyClient.lib(~50 KB) with noTRACY_ENABLEin itsINTERFACE_COMPILE_DEFINITIONS. The build linked fine, but everyZoneScopedexpanded to a no-op and the profiler couldn't see the game.on-demandfeature in the project's vcpkg manifest so the client emits data only while a profiler is connected (≈0 runtime overhead when nothing is attached).version-stringto0.13.3-1f1738c2-enableso vcpkg invalidates its binary cache and rebuilds with the new options.After the fix
TracyClient.libgrows from ~50 KB → ~2.4 MB, and the exportedTracy::TracyClienttarget carriesINTERFACE_COMPILE_DEFINITIONS = TRACY_ENABLE;TRACY_ON_DEMANDso every consumer that links it gets real instrumentation automatically.Test plan
BuildRelease.bat ALL-WITH-AUTO-DEPLOYMENT(withTRACY_SUPPORT=ON) succeeds;CommunityShaders.dlldeploys to SE + VR Data folders127.0.0.1:8086Deferred,Skylighting,Upscaling,SSGI,TerrainBlending,LightLimitFix, etc.TRACY_SUPPORT=OFF(default) — should be a no-op for non-profiling builds since the port-level options only matter when the library is linked🤖 Generated with Claude Code
Summary by CodeRabbit