fix(vr): restore PerfMode/foveated DLSS output height#128
Conversation
The v1.7.0 upstream sync's VR-restore revert (47821fa, "Revert 'remove all VR support'") re-applied upstream's `dlssOptions.outputHeight = state->screenSize.y` immediately after the fork's PerfMode/foveation-aware line, silently clobbering it. Under PerfMode, state->screenSize.y is the renderRes-polluted spoofed HMD size, so DLSS was configured with a renderRes output height that no longer matches the displayRes output extent. NGX requires outputHeight == extentOut.height (see the comment above the restored line) or it zeroes the output; it also discarded the FoveatedRender subrect height passed in `height`. Remove the duplicate so the intended height (DisplayRes under PerfMode, subrect height under FoveatedRender, screenSize otherwise) reaches NGX. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 53 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Restores VR-specific DLSS output height selection in Streamline::SetDLSSOptions by removing a duplicate assignment that overwrote the intended PerfMode/foveated-aware height, which could cause NGX to produce zeroed output when outputHeight mismatched extentOut.height.
Changes:
- Removes a redundant
dlssOptions.outputHeight = state->screenSize.yassignment that clobbered the PerfMode/foveated-aware output height. - Removes a redundant
dlssOptions.outputWidth = widthline (already set immediately prior).
|
No actionable suggestions for changed features. |
|
✅ A pre-release build is available for this PR: |
Problem
The v1.7.0 upstream sync (#121) — specifically the VR-restore revert
47821fa6a("Revert 'remove all VR support (community-shaders#2475)'") — re-applied upstream's plaindlssOptions.outputHeight = state->screenSize.yimmediately after the fork's PerfMode/foveation-aware line inStreamline::SetDLSSOptions, silently clobbering it:Confirmed via
git show 47821fa6a -- src/Features/Upscaling/Streamline.cpp(the two lines are+additions from that commit).Impact
Under PerfMode (
renderAtUpscaleRes),state->screenSize.yis the renderRes-polluted spoofed HMD size, so DLSS was told a renderRes output height that no longer matches the displayRes output extent. NGX requiresoutputHeight == extentOut.height(documented in the comment directly above the clobbered line) or it zeroes the output. The clobber also discards the FoveatedRender subrect height passed viaheight.Fix
Remove the duplicate so the intended height reaches NGX:
screenSizeotherwise.Net
-3lines; restores the behavior that shipped before the sync.🤖 Generated with Claude Code