Skip to content

fix(vr): restore PerfMode/foveated DLSS output height#128

Merged
alandtse merged 1 commit into
devfrom
fix/dlss-output-height-clobber
Jun 8, 2026
Merged

fix(vr): restore PerfMode/foveated DLSS output height#128
alandtse merged 1 commit into
devfrom
fix/dlss-output-height-clobber

Conversation

@alandtse

@alandtse alandtse commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Problem

The v1.7.0 upstream sync (#121) — specifically the VR-restore revert 47821fa6a ("Revert 'remove all VR support (community-shaders#2475)'") — re-applied upstream's plain dlssOptions.outputHeight = state->screenSize.y immediately after the fork's PerfMode/foveation-aware line in Streamline::SetDLSSOptions, silently clobbering it:

dlssOptions.outputHeight = height != 0 ? height
    : (dlssperfActive ? (uint)perfMode.GetDisplayScreenSize().y : (uint)state->screenSize.y);  // fork (intended)
dlssOptions.outputWidth  = width;                       // <- re-added by the revert
dlssOptions.outputHeight = (uint)state->screenSize.y;   // <- clobbers the line above

Confirmed via git show 47821fa6a -- src/Features/Upscaling/Streamline.cpp (the two lines are + additions from that commit).

Impact

Under PerfMode (renderAtUpscaleRes), state->screenSize.y is the renderRes-polluted spoofed HMD size, so DLSS was told a renderRes output height that no longer matches the displayRes output extent. NGX requires outputHeight == extentOut.height (documented in the comment directly above the clobbered line) or it zeroes the output. The clobber also discards the FoveatedRender subrect height passed via height.

Fix

Remove the duplicate so the intended height reaches NGX:

  • DisplayRes under PerfMode,
  • subrect height under FoveatedRender,
  • screenSize otherwise.

Net -3 lines; restores the behavior that shipped before the sync.

🤖 Generated with Claude Code

The v1.7.0 upstream sync's VR-restore revert (47821fa, "Revert
'remove all VR support'") re-applied upstream's
`dlssOptions.outputHeight = state->screenSize.y` immediately after the
fork's PerfMode/foveation-aware line, silently clobbering it.

Under PerfMode, state->screenSize.y is the renderRes-polluted spoofed
HMD size, so DLSS was configured with a renderRes output height that no
longer matches the displayRes output extent. NGX requires
outputHeight == extentOut.height (see the comment above the restored
line) or it zeroes the output; it also discarded the FoveatedRender
subrect height passed in `height`.

Remove the duplicate so the intended height (DisplayRes under PerfMode,
subrect height under FoveatedRender, screenSize otherwise) reaches NGX.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 8, 2026 08:44
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@alandtse, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 28 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78365f24-2280-46cc-a532-1d5f9b56bda2

📥 Commits

Reviewing files that changed from the base of the PR and between 9ba726a and 46e5978.

📒 Files selected for processing (1)
  • src/Features/Upscaling/Streamline.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dlss-output-height-clobber

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores VR-specific DLSS output height selection in Streamline::SetDLSSOptions by removing a duplicate assignment that overwrote the intended PerfMode/foveated-aware height, which could cause NGX to produce zeroed output when outputHeight mismatched extentOut.height.

Changes:

  • Removes a redundant dlssOptions.outputHeight = state->screenSize.y assignment that clobbered the PerfMode/foveated-aware output height.
  • Removes a redundant dlssOptions.outputWidth = width line (already set immediately prior).

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

No actionable suggestions for changed features.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@alandtse alandtse merged commit d1ab536 into dev Jun 8, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants