ci: swap to microsoft/setup-msbuild#12
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
alandtse
added a commit
that referenced
this pull request
May 20, 2026
Add a new "Remote Control" CORE feature that hosts an embedded Model Context Protocol (MCP) server inside CommunityShaders.dll so AI assistants (Claude Code, Cursor, Continue, etc.) can query and mutate runtime state for A/B testing and performance investigation. Server is off by default and binds to 127.0.0.1 — opt-in via the Settings UI. The ImGui panel exposes a "Copy MCP client config to clipboard" button that emits a Streamable-HTTP (MCP 2025-03-26) config snippet ready to paste into a host's mcpServers settings. Initial slice ships a single bootstrap tool (get_state) so the end-to-end wiring can be validated; subsequent commits will add list_features, get/set/toggle/reset_feature, run_abtest, capture_renderdoc, and capture_screenshot. Library choice: hkr04/cpp-mcp pinned to a0eb22c9 (280 stars, MIT, 2025-03-26 spec compliant including Streamable HTTP). Vendored as a submodule under extern/cpp-mcp — same pattern as FidelityFX-SDK and Streamline — because cpp-mcp has no install rules (upstream PR #12 still open). Only the server-side translation units are compiled; the bundled stdio/SSE *client* implementations are intentionally omitted. The library vendors its own nlohmann_json (3.11.3) which has a different ABI namespace tag than vcpkg's (3.12.0) and would cause LNK2001 on mcp::server::set_capabilities / register_tool if cpp-mcp linked against the vendored copy and consumers against vcpkg. cmake/cpp-mcp.cmake patches mcp_message.h at configure time to use <nlohmann/json.hpp> from vcpkg, writing the patched header to a build-tree mirror so the submodule stays clean. cpp-mcp's vendored cpp-httplib pulls in <winsock2.h>, but Skyrim's PCH transitively brings the legacy <winsock.h> via <Windows.h>. Define _WINSOCKAPI_ on the cpp-mcp target (PUBLIC) so consumers and the PCH skip the legacy header. Wiring: * extern/cpp-mcp submodule pinned to hkr04/cpp-mcp@a0eb22c9 * cmake/cpp-mcp.cmake builds the static library target * features/Remote Control/CORE marker + versioned ini * src/Features/RemoteControl.{h,cpp} (Feature subclass) * registered in globals::features and Feature::GetFeatureList Verified end-to-end: CommunityShaders.dll builds clean, grows ~500 KB, deploys to SE+VR. Off-by-default toggle exposed in the Core Features → Utility group of the in-game menu. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alandtse
added a commit
that referenced
this pull request
May 20, 2026
Add a new "Remote Control" CORE feature that hosts an embedded Model Context Protocol (MCP) server inside CommunityShaders.dll so AI assistants (Claude Code, Cursor, Continue, etc.) can query and mutate runtime state for A/B testing and performance investigation. Server is off by default and binds to 127.0.0.1 — opt-in via the Settings UI. The ImGui panel exposes a "Copy MCP client config to clipboard" button that emits a Streamable-HTTP (MCP 2025-03-26) config snippet ready to paste into a host's mcpServers settings. Initial slice ships a single bootstrap tool (get_state) so the end-to-end wiring can be validated; subsequent commits will add list_features, get/set/toggle/reset_feature, run_abtest, capture_renderdoc, and capture_screenshot. Library choice: hkr04/cpp-mcp pinned to a0eb22c9 (280 stars, MIT, 2025-03-26 spec compliant including Streamable HTTP). Vendored as a submodule under extern/cpp-mcp — same pattern as FidelityFX-SDK and Streamline — because cpp-mcp has no install rules (upstream PR #12 still open). Only the server-side translation units are compiled; the bundled stdio/SSE *client* implementations are intentionally omitted. The library vendors its own nlohmann_json (3.11.3) which has a different ABI namespace tag than vcpkg's (3.12.0) and would cause LNK2001 on mcp::server::set_capabilities / register_tool if cpp-mcp linked against the vendored copy and consumers against vcpkg. cmake/cpp-mcp.cmake patches mcp_message.h at configure time to use <nlohmann/json.hpp> from vcpkg, writing the patched header to a build-tree mirror so the submodule stays clean. cpp-mcp's vendored cpp-httplib pulls in <winsock2.h>, but Skyrim's PCH transitively brings the legacy <winsock.h> via <Windows.h>. Define _WINSOCKAPI_ on the cpp-mcp target (PUBLIC) so consumers and the PCH skip the legacy header. Wiring: * extern/cpp-mcp submodule pinned to hkr04/cpp-mcp@a0eb22c9 * cmake/cpp-mcp.cmake builds the static library target * features/Remote Control/CORE marker + versioned ini * src/Features/RemoteControl.{h,cpp} (Feature subclass) * registered in globals::features and Feature::GetFeatureList Verified end-to-end: CommunityShaders.dll builds clean, grows ~500 KB, deploys to SE+VR. Off-by-default toggle exposed in the Core Features → Utility group of the in-game menu. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alandtse
added a commit
that referenced
this pull request
May 21, 2026
Add a new "Remote Control" CORE feature that hosts an embedded Model Context Protocol (MCP) server inside CommunityShaders.dll so AI assistants (Claude Code, Cursor, Continue, etc.) can query and mutate runtime state for A/B testing and performance investigation. Server is off by default and binds to 127.0.0.1 — opt-in via the Settings UI. The ImGui panel exposes a "Copy MCP client config to clipboard" button that emits a Streamable-HTTP (MCP 2025-03-26) config snippet ready to paste into a host's mcpServers settings. Initial slice ships a single bootstrap tool (get_state) so the end-to-end wiring can be validated; subsequent commits will add list_features, get/set/toggle/reset_feature, run_abtest, capture_renderdoc, and capture_screenshot. Library choice: hkr04/cpp-mcp pinned to a0eb22c9 (280 stars, MIT, 2025-03-26 spec compliant including Streamable HTTP). Vendored as a submodule under extern/cpp-mcp — same pattern as FidelityFX-SDK and Streamline — because cpp-mcp has no install rules (upstream PR #12 still open). Only the server-side translation units are compiled; the bundled stdio/SSE *client* implementations are intentionally omitted. The library vendors its own nlohmann_json (3.11.3) which has a different ABI namespace tag than vcpkg's (3.12.0) and would cause LNK2001 on mcp::server::set_capabilities / register_tool if cpp-mcp linked against the vendored copy and consumers against vcpkg. cmake/cpp-mcp.cmake patches mcp_message.h at configure time to use <nlohmann/json.hpp> from vcpkg, writing the patched header to a build-tree mirror so the submodule stays clean. cpp-mcp's vendored cpp-httplib pulls in <winsock2.h>, but Skyrim's PCH transitively brings the legacy <winsock.h> via <Windows.h>. Define _WINSOCKAPI_ on the cpp-mcp target (PUBLIC) so consumers and the PCH skip the legacy header. Wiring: * extern/cpp-mcp submodule pinned to hkr04/cpp-mcp@a0eb22c9 * cmake/cpp-mcp.cmake builds the static library target * features/Remote Control/CORE marker + versioned ini * src/Features/RemoteControl.{h,cpp} (Feature subclass) * registered in globals::features and Feature::GetFeatureList Verified end-to-end: CommunityShaders.dll builds clean, grows ~500 KB, deploys to SE+VR. Off-by-default toggle exposed in the Core Features → Utility group of the in-game menu. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alandtse
added a commit
that referenced
this pull request
May 21, 2026
Add a new "Remote Control" CORE feature that hosts an embedded Model Context Protocol (MCP) server inside CommunityShaders.dll so AI assistants (Claude Code, Cursor, Continue, etc.) can query and mutate runtime state for A/B testing and performance investigation. Server is off by default and binds to 127.0.0.1 — opt-in via the Settings UI. The ImGui panel exposes a "Copy MCP client config to clipboard" button that emits a Streamable-HTTP (MCP 2025-03-26) config snippet ready to paste into a host's mcpServers settings. Initial slice ships a single bootstrap tool (get_state) so the end-to-end wiring can be validated; subsequent commits will add list_features, get/set/toggle/reset_feature, run_abtest, capture_renderdoc, and capture_screenshot. Library choice: hkr04/cpp-mcp pinned to a0eb22c9 (280 stars, MIT, 2025-03-26 spec compliant including Streamable HTTP). Vendored as a submodule under extern/cpp-mcp — same pattern as FidelityFX-SDK and Streamline — because cpp-mcp has no install rules (upstream PR #12 still open). Only the server-side translation units are compiled; the bundled stdio/SSE *client* implementations are intentionally omitted. The library vendors its own nlohmann_json (3.11.3) which has a different ABI namespace tag than vcpkg's (3.12.0) and would cause LNK2001 on mcp::server::set_capabilities / register_tool if cpp-mcp linked against the vendored copy and consumers against vcpkg. cmake/cpp-mcp.cmake patches mcp_message.h at configure time to use <nlohmann/json.hpp> from vcpkg, writing the patched header to a build-tree mirror so the submodule stays clean. cpp-mcp's vendored cpp-httplib pulls in <winsock2.h>, but Skyrim's PCH transitively brings the legacy <winsock.h> via <Windows.h>. Define _WINSOCKAPI_ on the cpp-mcp target (PUBLIC) so consumers and the PCH skip the legacy header. Wiring: * extern/cpp-mcp submodule pinned to hkr04/cpp-mcp@a0eb22c9 * cmake/cpp-mcp.cmake builds the static library target * features/Remote Control/CORE marker + versioned ini * src/Features/RemoteControl.{h,cpp} (Feature subclass) * registered in globals::features and Feature::GetFeatureList Verified end-to-end: CommunityShaders.dll builds clean, grows ~500 KB, deploys to SE+VR. Off-by-default toggle exposed in the Core Features → Utility group of the in-game menu. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.