Conversation
alandtse
added a commit
that referenced
this pull request
Jun 3, 2026
Addresses the minor hardening items in #87 (pre-existing, surfaced by CodeRabbit on #56): - Particle.cpp: guard the dimmer interpolation against lightFadeEnd <= lightFadeStart so equal engine fade globals can't divide by zero (NaN/Inf into GPU lighting). - ParticleLights.cpp: std::sort the get_configs results before the 'first wins' duplicate dedupe so the surviving config is deterministic across installs (both ParticleLights and Gradients loops). - ParticleLights.cpp: require exactly 6 or 8 hex digits for gradient colors so malformed widths (#1, #12345) fail closed instead of packing a garbage 32-bit color. - Upscaling.cpp: clamp the stored streamlineLogLevel (not just the UI index) so a stale/hand-edited out-of-range value can't persist through the save / restart-diff paths. Closes #87
alandtse
added a commit
that referenced
this pull request
Jun 3, 2026
Addresses the minor hardening items in #87 (pre-existing, surfaced by CodeRabbit on #56): - Particle.cpp: guard the dimmer interpolation against lightFadeEnd <= lightFadeStart so equal engine fade globals can't divide by zero (NaN/Inf into GPU lighting). - ParticleLights.cpp: std::sort the get_configs results before the 'first wins' duplicate dedupe so the surviving config is deterministic across installs (both ParticleLights and Gradients loops). - ParticleLights.cpp: require exactly 6 or 8 hex digits for gradient colors so malformed widths (#1, #12345) fail closed instead of packing a garbage 32-bit color. - Upscaling.cpp: clamp the stored streamlineLogLevel (not just the UI index) so a stale/hand-edited out-of-range value can't persist through the save / restart-diff paths. Closes #87
alandtse
added a commit
that referenced
this pull request
Jun 3, 2026
Addresses the minor hardening items in #87 (pre-existing, surfaced by CodeRabbit on #56): - Particle.cpp: guard the dimmer interpolation against lightFadeEnd <= lightFadeStart so equal engine fade globals can't divide by zero (NaN/Inf into GPU lighting). - ParticleLights.cpp: std::sort the get_configs results before the 'first wins' duplicate dedupe so the surviving config is deterministic across installs (both ParticleLights and Gradients loops). - ParticleLights.cpp: require exactly 6 or 8 hex digits for gradient colors so malformed widths (#1, #12345) fail closed instead of packing a garbage 32-bit color. - Upscaling.cpp: clamp the stored streamlineLogLevel (not just the UI index) so a stale/hand-edited out-of-range value can't persist through the save / restart-diff paths. Closes #87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.