Restore NOTIFICATION_CHANGE #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial revert of 8f0dfa2 to restore NOTIFICATION_CHANGE functionality for timers and alarms.
for more information, see https://pre-commit.ci
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores NOTIFICATION_CHANGE events for updating alarms and timers, which Amazon appears to support via HTTP2 notifications. This restores alarm and timer updates via changes in the Alexa app. I've kept PUSH_ACTIVITY as well as there does not seem to be any downside in responding to both event types and Amazon may be inconsistent in their implementation across different regions.
Partial revert of 8f0dfa2 to restore NOTIFICATION_CHANGE functionality for timers and alarms.