Add support to tts.cloud_say #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks. I can ignore the validate error but please fix the pre-commit requirements. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
All the pre-commit issues are sorted, except of one. That is "comment", which is not comment, but string literal. But this is taken from original repo and is spread through the code, not just this place. |
|
The issue is you put code above the docstring. Your code addition needs to be under it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Alexa notifitaction service doesn't support many languages, and doesn't support tts.cloud_day.
This PR adds support to tts.cloud_say by converting cloud generated mp3 via ffmpeg to format accepted by Alexa, and then playing that mp3. For this to work, HA instance has to be publicly accessible (either via Nabu Casa cloud subscription or any other custom solution), and for that reason, new setting was added to integration configuration.