Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to more modern toolset (Vite, Vitest, Playwright) + Upgrade dependencies + More Improvements #152

Merged
merged 34 commits into from
May 14, 2024
Merged

Migrate to more modern toolset (Vite, Vitest, Playwright) + Upgrade dependencies + More Improvements #152

merged 34 commits into from
May 14, 2024

Conversation

alan2207
Copy link
Owner

@alan2207 alan2207 commented Apr 28, 2024 •
edited
Loading

Considering the fact that the project was built nearly 3 years ago, it was about time to revisit it and make the necessary updates. This PR includes the following changes:

  • Updated docs
  • All packages have been upgraded to their latest major versions (except ESLint which was upgraded to v8, let's wait for v9 a bit)
  • Switching from CRA to Vite, which was the most requested and the most obvious change.
  • Switching from Jest to Vitest, since Vitest integrates well with the Vite setup, is well maintained and there are far fewer issues.
  • Switching from Cypress to Playwright which is a more powerful and modern e2e-testing tool.
  • Storing auth token in cookie over localStorage.
  • Validating env variables with zod.
  • Updating UI by moving to using ShadCN UI
  • Switching to kebab case files for all files
  • Improving react-query usage
  • More improvements

@netlify Netlify
Copy link

netlify bot commented Apr 28, 2024 •
edited
Loading

✅ Deploy Preview for bulletproof-react-app ready!

Name Link
🔨 Latest commit 1fb422b
🔍 Latest deploy log https://app.netlify.com/sites/bulletproof-react-app/deploys/66430737ce966200083e7410
😎 Deploy Preview https://deploy-preview-152--bulletproof-react-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alan2207 alan2207 mentioned this pull request Apr 28, 2024
Closed
alan2207 added 9 commits May 14, 2024 08:37
@alan2207
update pipeline
dd427db 
do not track dist folder

fix base

update

update pipeline steps

reduce test flakiness

update e2e test

check if env variables are passed to e2e test

update

try without mocks

update

try not rendering app, will the worker get initialized?

try empty handlers

update

update
@alan2207
upgrade rest of dependencies
d5d4355
@alan2207
update docs
4243e83
@alan2207
add some changes from #153
8a83d18
@alan2207
no need to run prettier, all formatting is handled by eslint-plugin-p…
5545b97 
…rettier
@alan2207
update react-query-auth
977a77e
@alan2207
update license
af4bfcf
@alan2207
update zustand mocks for testing
0658e52
@alan2207
validate env variables
74c7612
@alan2207 alan2207 marked this pull request as ready for review May 14, 2024 06:46
@alan2207 alan2207 changed the title Migrate to more modern toolset (Vite, Vitest, Playwright) + Upgrade dependencies Migrate to more modern toolset (Vite, Vitest, Playwright) + Upgrade dependencies + More Improvements May 14, 2024
@alan2207 alan2207 merged commit 17ad2a7 into master May 14, 2024
8 checks passed
@alan2207 alan2207 mentioned this pull request May 14, 2024
Closed
@ThePiyushAggarwal
Copy link

This is great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alan2207 @ThePiyushAggarwal @mohamadboufi678