-
Notifications
You must be signed in to change notification settings - Fork 19
Improve emulator re-initialisation #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Just adding a note here as ran into this when working with a GP subclass for the error quantification. This call: autoemulate/autoemulate/core/compare.py Line 578 in 76689ae
fails since: autoemulate/autoemulate/emulators/__init__.py Lines 68 to 70 in 76689ae
doesn't also look at: autoemulate/autoemulate/emulators/gaussian_process/exact.py Lines 460 to 463 in 76689ae
@radka-j - adding here as it might be addressed by the upcoming changes to this API? But if not happy to open a new issue to look at this. An option could also be to revisit having a central registry class to handle this uniformly. |
@sgreenbury I don't think we should ever use the |
It was the GP context (passing a But thinking more about it, it affects any subclass used by class SimpleFNN(PyTorchBackend):
...
ae = AutoEmulate(x, y, models=[SimpleFNN])
ae.fit_from_reinitialized(x, y) since I think if the emulator becomes the entity that does the refitting in this PR then a global emulator registry including all custom subclasses would not be needed for this but might still be useful? |
Closes #748
Closes #757
Closes #874
Overview:
**kwargs
with optional keyword arguments to match use (they are mostly used to handle for scheduler kwargs)TODOs: