-
Notifications
You must be signed in to change notification settings - Fork 22
Add initial emulator base class for The Well #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgreenbury
wants to merge
33
commits into
main
Choose a base branch
from
828-the-well-explore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
9ccb817 to
476f83f
Compare
- Add ReactionDiffusionDataset with metadata - Revise base class to be `WellDataModule`
- Add advection-diffusion - Add BOUT++ - Add support to read from torch
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #828.
Update
I think this now ready to merge with the following additions following discussion:
Next steps
These include:
Trainerand API here. Adding trainable temporal weights in the loss with a look ahead for e.g. m steps can be an option to test the flexibility of the implementationthe-wellas a dep Explore and discuss potential limitations addingthe_wellas a dep #852If the above look possible, we later might consider moving the training into the
SpatioTemporalEmulatorbase class so this API for training and model structure is available by default in subclasses of our spatiotemporal emulator.Notes
The deps need to be updated:
For the BOUT++, the torch tensor is split beforehand into the following expected files to be read for train, valid, test:
base_path/train/data.ptbase_path/valid/data.ptbase_path/test/data.pt