Skip to content

Conversation

@radka-j
Copy link
Member

@radka-j radka-j commented Jun 25, 2025

Closes #538

The reason we turned execution off was because the workflow example was getting interrupted. This should just skip the workflow execution but run everything else. It feels we should merge this before merging #554

I also removed exclude_tags as that was added to try to stop execution of certain notebooks and it did not work.

@radka-j radka-j requested a review from sgreenbury June 25, 2025 14:19
Copy link
Collaborator

@sgreenbury sgreenbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  tests
  test_compare.py
Project Total  

This report was generated by python-coverage-comment-action

@radka-j radka-j merged commit 311b5bf into main Jun 25, 2025
4 checks passed
@radka-j radka-j deleted the execute_nb branch June 25, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit CI to generate notebook outputs for docs

2 participants