Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thoni56, there are a number of things that need to be fixed or added in Ch, 5, so I'm opening a PR and start proposing changes one commit at the time (so if we don't like something we can revert the commit).
I'm also annotating in comments the various problems that need to be addressed, so feel free to add their fixes by adding your commits to this branch.
Last time we used a PR to co-edit a chapter we ended up having trouble using the reviews system. Let's see if this time we can manage to handle discussing the various fixes without getting entangled with the reviews system.
Pending Tasks
In §5.1, first paragraph, clarify if
Start At
counts as a turn, i.e. if EVENTs and SCRIPTs are executed withinStart
, and what turn it will be after that (turn 0 or 1?).We should clarify somewhere in this chapter what makes a turn click and what doesn't. E.g. META VERBs don't advance a turn, so EVENTs and SCRIPTs aren't executed. A misunderstood command doesn't count, right? What about failed CHECKs? or attempting to use a VERB that violates the WHERE clause of the syntax? Authors needs this info to understand how turns interact with EVENTs and SCRIPTs. There's already a phrase stating:
so maybe this info should go there.
Clarify THEM player-word (see The THEM Conundrum #127).