Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Ch 5. Running An Adventure #126

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Revise Ch 5. Running An Adventure #126

merged 1 commit into from
Dec 5, 2021

Conversation

tajmone
Copy link
Collaborator

@tajmone tajmone commented Sep 1, 2021

@thoni56, there are a number of things that need to be fixed or added in Ch, 5, so I'm opening a PR and start proposing changes one commit at the time (so if we don't like something we can revert the commit).

I'm also annotating in comments the various problems that need to be addressed, so feel free to add their fixes by adding your commits to this branch.

Last time we used a PR to co-edit a chapter we ended up having trouble using the reviews system. Let's see if this time we can manage to handle discussing the various fixes without getting entangled with the reviews system.

Pending Tasks

  • In §5.1, first paragraph, clarify if Start At counts as a turn, i.e. if EVENTs and SCRIPTs are executed within Start, and what turn it will be after that (turn 0 or 1?).

  • We should clarify somewhere in this chapter what makes a turn click and what doesn't. E.g. META VERBs don't advance a turn, so EVENTs and SCRIPTs aren't executed. A misunderstood command doesn't count, right? What about failed CHECKs? or attempting to use a VERB that violates the WHERE clause of the syntax? Authors needs this info to understand how turns interact with EVENTs and SCRIPTs. There's already a phrase stating:

    If the player enters an empty command, this is equivalent to forfeiting the turn.

    so maybe this info should go there.

  • Clarify THEM player-word (see The THEM Conundrum #127).

@tajmone tajmone force-pushed the ch5-running-adventure branch from eac3248 to 431dab7 Compare September 1, 2021 10:01
@tajmone tajmone marked this pull request as draft September 1, 2021 10:59
@tajmone
Copy link
Collaborator Author

tajmone commented Sep 23, 2021

@thoni56, could you help me understand better the points listed above? so I can start updating the text.

@tajmone tajmone force-pushed the ch5-running-adventure branch from 0c98073 to a169365 Compare September 23, 2021 13:44
@tajmone tajmone force-pushed the ch5-running-adventure branch from a169365 to 923c75d Compare October 20, 2021 06:37
@tajmone tajmone force-pushed the ch5-running-adventure branch from 923c75d to ff7dedc Compare November 22, 2021 06:30
@tajmone tajmone force-pushed the ch5-running-adventure branch from ff7dedc to 82930b6 Compare December 5, 2021 10:19
@thoni56 thoni56 marked this pull request as ready for review December 5, 2021 12:51
@tajmone tajmone mentioned this pull request Dec 5, 2021
3 tasks
Polish "5. Running An Adventure" by rephrasing some paragraphs,
cleaning-up some formatting, annotating pending fixes, and other fixes
that were planned for PR #126, which had to be squashed prematurely to 
allow the book partitioning changes planned in #133.
@tajmone tajmone force-pushed the ch5-running-adventure branch from 82930b6 to 184ceba Compare December 5, 2021 16:30
@tajmone tajmone merged commit 176597f into master Dec 5, 2021
@tajmone tajmone deleted the ch5-running-adventure branch December 5, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant