Fix insufficient synchronization in examples #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples use `Arc::strong_count` in order to await all other threads having terminated. Unfortunately, `Arc::strong_count` uses a `Relaxed` atomic to load the value, so this can not be used to establish an ordering, and later leads to a weak memory data race. The alternative is to use `get_mut`, which uses the internal `is_unique` function, which is unfortunately private and therefore not usable directly.
|
Thanks! |
|
Oh no, you were to quick 🚀 I just saw the same problem is present in But thanks for merging! |
JoJoDeveloping
added a commit
to JoJoDeveloping/skl
that referenced
this pull request
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 79.22% 79.14% -0.08%
==========================================
Files 9 9
Lines 2609 2609
==========================================
- Hits 2067 2065 -2
- Misses 542 544 +2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
This is another instance of rust-lang/rust#117485, mentioning this here so it is referenced there.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples use
Arc::strong_countin order to await all other threads having terminated. Unfortunately,Arc::strong_countuses aRelaxedatomic to load the value, so this can not be used to establish an ordering, and later leads to a weak memory data race. The alternative is to useArc::get_mut, which uses the internalis_uniquefunction, which is unfortunately private and therefore not usable directly.