-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes, Skip Improvements, Recommended Anime, and other improvements #157
Conversation
…y when new episode is available & improve progress
could you make some additions to the skip intro / skip outro system? if you don't have time/you can't do it now there are no problems of course, I asked you just because you build the whole aniskip system edit: thanks! |
Added it lmk if there is anything else you'd be interested in me adding or if there is anything wrong with it. It'll only autoplay to the next episode if there is less than 15 seconds left of the video after skipping to the end of the outro. |
@aleganza If you could make a dropdown for the anime section where the section title is that'd be greatly appreciated so instead of having the recommended anime and the related anime next to each other it can just be one section. |
sorry can you provide an example |
sorry I don't really have any paint tools installed rn but if you could make where the text is like 'Related' or 'Recommended' into a dropdown list so you can choose between Related or Recommended. Edit: didn't realize how easy it was to just put a Select element where the label should be. |
I thought this was the cause for some lag, it is not.
Causes more problems in the long run then it fixes.
if I can, tomorrow I'll review it |
Found some more bugs so I'm going to set it as a draft until I can fix them. |
ook. please list those bugs in the pr description in another selectable list |
about the bug fixex: modals must not be deleted, otherwise it would have to fetch episodes info again btw, is the lag from the video player happening only in THIS pr, or in the current released akuse? |
It isn't caching anything for the player only anime info so you don't have to search for the anime every time you press next episode.
Nope seems that having a delay for mouse movement caused the "lag" I was trying to fix (or I did something else that fixed it). Seems to be some other lag which is only caused when the video is playing no idea what's causing it though since it's been like that since before I've made any PRs (I tested 1.5.0 and it has it), probably hls. It isn't noticeable enough to see any differences except for when you're interacting with the UI stuff like the pause icon.
currently released |
can you try with 1.3.0 too? |
Happens with 1.3.0 as well |
ok I have it too sometimes with all the versions on the pc I'm actually using (thinkpad t450), I didn't have it when using akuse on my home desktop. |
wow thanks for hianime! it provides so many languages |
Ah forgot that I bottlenecked my cpu to 1GHz because it was overheating too much probably why lol |
oh it must be that then. |
Nah removed setting the anime as paused though the issue seems to be a preference for them so I didn't really put all that much effort into fixing it. |
forgot to add add some stuff to the previous PR which is why I marked as a draft.
Todo
Changes
Issues
Screenshots