Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes, Skip Improvements, Recommended Anime, and other improvements #157

Merged
merged 56 commits into from
Oct 8, 2024

Conversation

ch0nker
Copy link
Contributor

@ch0nker ch0nker commented Sep 23, 2024

forgot to add add some stuff to the previous PR which is why I marked as a draft.

Todo

  • Update cached episodes list if a new episode exists.
  • Try to figure out what's causing the video player to lag so much.
  • Fix skip event progress bars counting as their own progress and if you hover over the start of them it'll show 0:00 instead of where ever the skip event starts at.
  • Fix title spacing
  • Second episode progress bar for showing how much is left

Changes

  • Fix setting seek time in the settings tab.
  • Update local history when new episode is available.
  • Better logic for getting related anime formats.
  • Show skip events on the progress bar.
  • Make skip button popup instead of having to interact with the video player for it to show.
  • Drop down for Recommended & Related anime, it'll default to Related if it's available.
  • Episode progress bars in the anime modal (needs some refining).
  • Recommended anime section that'll use a random history entry.
  • Batch fetch anilist watch history instead of making a bunch of requests.
  • 18+ filter.
  • Cache anime data so getting episode info doesn't take as long.
  • HiAnime source

Issues

Screenshots

Screenshot_20240923_031202
Screenshot_20240923_101440
Screenshot_20240923_221207
Screenshot_20240925_002619
Screenshot_20240929_091948
Screenshot_20240929_092701

…y when new episode is available & improve progress
@aleganza
Copy link
Member

aleganza commented Sep 23, 2024

could you make some additions to the skip intro / skip outro system?
like reproducing Netflix behaviors, so the skip intro button pops out apart from the video player controls, stays there for 5 seconds and then it disappears.
then, implementing the "auto next episode" to the skip outro button. same way, when the skip outro button pops out, it stays for 5 seconds and then it automatically skips to the next episode/to the sequel.

if you don't have time/you can't do it now there are no problems of course, I asked you just because you build the whole aniskip system

edit: thanks!

@ch0nker
Copy link
Contributor Author

ch0nker commented Sep 23, 2024

could you make some additions to the skip intro / skip outro system? like reproducing Netflix behaviors, so the skip intro button pops out apart from the video player controls, stays there for 5 seconds and then it disappears. then, implementing the "auto next episode" to the skip outro button. same way, when the skip outro button pops out, it stays for 5 seconds and then it automatically skips to the next episode/to the sequel.

if you don't have time/you can't do it now there are no problems of course, I asked you just because you build the whole aniskip system

edit: thanks!

Added it lmk if there is anything else you'd be interested in me adding or if there is anything wrong with it.

It'll only autoplay to the next episode if there is less than 15 seconds left of the video after skipping to the end of the outro.

@ch0nker ch0nker changed the title Bug fixes Bug fixes, Skip Improvements, and Recommended Anime Sep 23, 2024
@ch0nker
Copy link
Contributor Author

ch0nker commented Sep 23, 2024

@aleganza If you could make a dropdown for the anime section where the section title is that'd be greatly appreciated so instead of having the recommended anime and the related anime next to each other it can just be one section.

@aleganza
Copy link
Member

sorry can you provide an example

@ch0nker
Copy link
Contributor Author

ch0nker commented Sep 23, 2024

sorry can you provide an example

sorry I don't really have any paint tools installed rn but if you could make where the text is like 'Related' or 'Recommended' into a dropdown list so you can choose between Related or Recommended.

Edit: didn't realize how easy it was to just put a Select element where the label should be.

@aleganza
Copy link
Member

aleganza commented Oct 6, 2024

if I can, tomorrow I'll review it

@ch0nker ch0nker marked this pull request as draft October 7, 2024 15:24
@ch0nker
Copy link
Contributor Author

ch0nker commented Oct 7, 2024

Found some more bugs so I'm going to set it as a draft until I can fix them.

@aleganza
Copy link
Member

aleganza commented Oct 7, 2024

ook.

please list those bugs in the pr description in another selectable list

@aleganza
Copy link
Member

aleganza commented Oct 7, 2024

about the bug fixex:

modals must not be deleted, otherwise it would have to fetch episodes info again
I would ask you to completely remove all the caching stuff related to the player. there is another method to improve the episode loading in-player, which I will do myself (and maybe that's causing the lag).

btw, is the lag from the video player happening only in THIS pr, or in the current released akuse?

@ch0nker
Copy link
Contributor Author

ch0nker commented Oct 7, 2024

I would ask you to completely remove all the caching stuff related to the player. there is another method to improve the episode loading in-player, which I will do myself (and maybe that's causing the lag).

It isn't caching anything for the player only anime info so you don't have to search for the anime every time you press next episode.

(and maybe that's causing the lag).

Nope seems that having a delay for mouse movement caused the "lag" I was trying to fix (or I did something else that fixed it). Seems to be some other lag which is only caused when the video is playing no idea what's causing it though since it's been like that since before I've made any PRs (I tested 1.5.0 and it has it), probably hls. It isn't noticeable enough to see any differences except for when you're interacting with the UI stuff like the pause icon.

btw, is the lag from the video player happening only in THIS pr, or in the current released akuse?

currently released

@ch0nker ch0nker marked this pull request as ready for review October 7, 2024 23:31
@ch0nker ch0nker marked this pull request as draft October 7, 2024 23:33
@ch0nker ch0nker marked this pull request as ready for review October 8, 2024 01:02
@aleganza
Copy link
Member

aleganza commented Oct 8, 2024

can you try with 1.3.0 too?

@ch0nker
Copy link
Contributor Author

ch0nker commented Oct 8, 2024

can you try with 1.3.0 too?

Happens with 1.3.0 as well

@aleganza
Copy link
Member

aleganza commented Oct 8, 2024

ok I have it too sometimes with all the versions on the pc I'm actually using (thinkpad t450), I didn't have it when using akuse on my home desktop.
what are your pc specs? I think it's related to that

@aleganza
Copy link
Member

aleganza commented Oct 8, 2024

wow thanks for hianime! it provides so many languages

@aleganza aleganza merged commit ab5969a into akuse-app:react-port Oct 8, 2024
@ch0nker
Copy link
Contributor Author

ch0nker commented Oct 8, 2024

what are your pc specs? I think it's related to that

Ah forgot that I bottlenecked my cpu to 1GHz because it was overheating too much probably why lol

@aleganza
Copy link
Member

aleganza commented Oct 8, 2024

oh it must be that then.
btw, did you completely fix #162 ?

@ch0nker
Copy link
Contributor Author

ch0nker commented Oct 8, 2024

btw, did you completely fix #162 ?

Nah removed setting the anime as paused though the issue seems to be a preference for them so I didn't really put all that much effort into fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants