Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): link to image repo correctly in Warehouse UI #3174

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

Sobuno
Copy link
Contributor

@Sobuno Sobuno commented Dec 22, 2024

Link was pointing relative to the current URL rather than to a repository. Reusing urlForImage function that was used for linking in the repo node already.

Before (See bottom of screenshot):
image

Now (See bottom of screenshot):
image

Link was pointing relative to the current URL rather than to a repository.

Signed-off-by: Jesper Vahlstrup Madsen <[email protected]>
@Sobuno Sobuno requested a review from a team as a code owner December 22, 2024 00:55
Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 73efeb9
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6776c8e4dd9f3b0008085779
😎 Deploy Preview https://deploy-preview-3174.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Marvin9 Marvin9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.40%. Comparing base (cd062f0) to head (73efeb9).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3174   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         288      288           
  Lines       26100    26108    +8     
=======================================
+ Hits        13416    13421    +5     
- Misses      11959    11961    +2     
- Partials      725      726    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marvin9
Copy link
Contributor

Marvin9 commented Jan 2, 2025

@Sobuno Could you just fix the UI lint and then it is good to go

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@krancour krancour enabled auto-merge January 2, 2025 17:12
@krancour krancour added this pull request to the merge queue Jan 2, 2025
Merged via the queue into akuity:main with commit bb95eb4 Jan 2, 2025
17 checks passed
@Sobuno Sobuno deleted the FixImageLinkInWarehouse branch January 2, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants