Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: minor fixes #32

Merged
merged 4 commits into from
Feb 8, 2018
Merged

lib: minor fixes #32

merged 4 commits into from
Feb 8, 2018

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Feb 8, 2018

First, a big thanks for maintaining this! 💚

I was skimming through the project and saw a few easy cleanups, which are rolled up in this PR:

@rubdos
Copy link
Contributor

rubdos commented Feb 8, 2018

Cool, thanks! I wondered whether the example on line 32 actually ran as a doctest; it does.

@akubera
Copy link
Owner

akubera commented Feb 8, 2018

Yeah I never thought to run clippy over this code for some reason...

Thanks a lot! I really appreciate it.

@akubera akubera merged commit f9b4edb into akubera:master Feb 8, 2018
@lucab
Copy link
Contributor Author

lucab commented Feb 9, 2018

For reference, there is one minor clippy warning inside a macro that I didn't fix.

@rubdos
Copy link
Contributor

rubdos commented Feb 9, 2018

Maybe we want clippy in travis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants