Updating to latest master

.azure-pipelines-preproduction/package.json

@@ -35,7 +35,7 @@
   },
   "scripts": {
     "test": "tsc && mocha -t 500000 --reporter min",
-    "spellcheck": "cspell \"specification/**/*.json\"",
+    "spellcheck": "ts-node ./scripts/spellcheck.ts",
     "tsc": "tsc",
     "multiapi": "ts-node ./scripts/multiapi.ts"
   }

.azure-pipelines/SwaggerToSDK.yml

@@ -1,6 +1,6 @@
 jobs:
 - job: "SDK"
-  timeoutInMinutes: 120
+  timeoutInMinutes: 180
   strategy:
     matrix:
       java:
@@ -9,9 +9,6 @@ jobs:
       javascript:
         AZURE_SDK_REPO: azure-sdk-for-js
         AZURE_SDK_PARAMS: ''
-      node:
-        AZURE_SDK_REPO: azure-sdk-for-node
-        AZURE_SDK_PARAMS: ''
       python:
         AZURE_SDK_REPO: azure-sdk-for-python
         AZURE_SDK_PARAMS: ''
@@ -25,4 +22,4 @@ jobs:
   steps:
   - script: echo $(NODE_OPTIONS)
   - script: "scripts/swagger-to-sdk.sh Azure/$(AZURE_SDK_REPO) -v $(AZURE_SDK_PARAMS)"
-    displayName: "Swagger to SDK script"
+    displayName: "Swagger to SDK script"

.github/reviewer.yml

@@ -0,0 +1,15 @@
+# This file is openapi-email-bot to store reviewer email address.
+---
+- group:
+    name: default
+    users:
+      - githubID: ruowan
+        email: ruowan@microsoft.com
+      - githubID: raych1
+        email: raychen@microsoft.com
+      - githubID: MyronFanQiu
+        email: fanqiu@microsoft.com
+      - githubID: yungezz
+        email: yungez@microsoft.com
+      - githubID: lirenhe
+        email: Renhe.Li@microsoft.com

.github/sla.yml

@@ -0,0 +1,25 @@
+---
+- scheduleTask:
+    action: sendEmailToAssignee
+    args:
+      ignoredLabels:
+        - WaitForARMFeedback
+        - DoNotMerge
+        - WaitingForAzureAPIBoard
+      limit: 48h
+      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
+      subject: "Action Required: Please respond to PR ${PR_URL}"
+    description: "None initial response in 48 hours"
+    name: no-initial-response
+- scheduleTask:
+    action: sendEmailToAssignee
+    args:
+      ignoredLabels:
+        - WaitForARMFeedback
+        - DoNotMerge
+        - WaitingForAzureAPIBoard
+      limit: 5d
+      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 5 days. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
+      subject: "Action Required: Please respond to PR ${PR_URL}"
+    description: "None update in PR in 5 days"
+    name: no-update-in-5d

CODEOWNERS

@@ -14,7 +14,7 @@
 /specification/consumption/ @kjeur @panda-wang
 /specification/containerinstance/ @samkreter
 /specification/containerregistry/ @djyou
-/specification/containerservice/ @mboersma
+/specification/containerservice/ @yangl900
 /specification/cosmos-db/ @dmakwana
 /specification/customer-insights/ @tjlvtao
 /specification/datafactory/ @zhangyd2015
@@ -43,7 +43,7 @@
 /specification/mobileengagement/ @pshrosbree
 /specification/monitor/ @gucalder
 /specification/mysql/ @qingqingyuan
-/specification/network/ @MikhailTryakhov
+/specification/network/ @MikhailTryakhov @number213
 /specification/notificationhubs/ @amolr @smithab
 /specification/operationalinsights/ @sw47
 /specification/operationsmanagement/ @dashimi16

custom-words.txt

@@ -496,6 +496,7 @@ featurized
 Featurizer
 feedbacktype
 FHIR
+filegroup
 filepath
 fileserver
 fileservers
@@ -1219,6 +1220,7 @@ scalesets
 scanability
 SCMS
 SCOM
+scopemap
 SCSV
 sdks
 searchindex
@@ -1487,6 +1489,7 @@ Unprovisions
 Unpublish
 Unregistering
 Unregisters
+unrestorable
 unsubstituted
 untagged
 Untracked

package.json

@@ -36,7 +36,7 @@
   "scripts": {
     "postinstall": "scripts/switch-to-preproduction.sh",
     "test": "tsc && mocha -t 500000 --reporter min",
-    "spellcheck": "cspell \"specification/**/*.json\"",
+    "spellcheck": "ts-node ./scripts/spellcheck.ts",
     "tsc": "tsc",
     "multiapi": "ts-node ./scripts/multiapi.ts"
   }

scripts/spellcheck.ts

@@ -0,0 +1,68 @@
+import { devOps, cli, childProcess } from '@azure/avocado';
+import { ExecOptions } from 'child_process';
+
+const logToAzureDevops = (msg: string, type: string) => {
+  const lines = msg.split('\n');
+  for (const line of lines) {
+    console.log(`##vso[task.logissue type=${type}]${line}`);
+  }
+}
+
+const logError = (msg: string) => logToAzureDevops(msg, 'error');
+const logWarn = (msg: string) => logToAzureDevops(msg, 'warning');
+
+const verboseExec = async (commandLine: string, options: ExecOptions = {}) => {
+  console.log(commandLine);
+  let result: any = {};
+  try {
+    result = await childProcess.exec(commandLine, options);
+  } catch (e) {
+    result = e;
+  }
+
+  if (!result.code) {
+    return 0;
+  }
+
+  if (result.stdout) {
+    logError(result.stdout);
+  }
+  if (result.stderr) {
+    console.error(result.stderr);
+  }
+  return result.code;
+}
+
+const main = async () => {
+  const config = cli.defaultConfig();
+  const pr = await devOps.createPullRequestProperties(config);
+  if (pr === undefined) {
+    logWarn("Not in CI environment. Run against all the spec json.");
+    return verboseExec(`cspell "specification/**/*.json"`);
+  }
+
+  const changedJsonFiles = await pr.structuralDiff()
+    .filter(filePath => filePath.endsWith('.json') && filePath.startsWith('specification/'))
+    .toArray();
+  if (changedJsonFiles.length === 0) {
+    logWarn("No changed spec json file");
+    return 0;
+  }
+
+  let retCode = 0;
+  for (const jsonFile of changedJsonFiles) {
+    const code = await verboseExec(`cspell ${jsonFile}`);
+    if (code !== 0) {
+      retCode = code;
+    }
+  }
+
+  return retCode;
+}
+
+main().then(retCode => {
+  if (retCode !== 0) {
+    logError('Please fix the error or add words to ./custom-words.txt');
+  }
+  process.exit(retCode);
+});

specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-01-01/definitions.json

@@ -850,10 +850,6 @@
         "openid": {
           "$ref": "#/definitions/OpenIdAuthenticationSettingsContract",
           "description": "OpenID Connect Authentication Settings"
-        },
-        "subscriptionKeyRequired": {
-          "type": "boolean",
-          "description": "Specifies whether subscription key is required during call to this API, true - API is included into closed products only, false - API is included into open products alone, null - there is a mix of products."
         }
       },
       "description": "API Authentication Settings."

specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2019-02-01-preview/appconfiguration.json

@@ -497,6 +497,57 @@
           "nextLinkName": "nextLink"
         }
       }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/listKeyValue": {
+      "post": {
+        "tags": [
+          "ConfigurationStores"
+        ],
+        "description": "Lists a configuration store key-value.",
+        "operationId": "ConfigurationStores_ListKeyValue",
+        "parameters": [
+          {
+            "$ref": "#/parameters/SubscriptionIdParameter"
+          },
+          {
+            "$ref": "#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/ConfigStoreNameParameter"
+          },
+          {
+            "$ref": "#/parameters/ApiVersionParameter"
+          },
+          {
+            "name": "listKeyValueParameters",
+            "in": "body",
+            "description": "The parameters for retrieving a key-value.",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/ListKeyValueParameters"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "The request was successful; the request was well-formed and received properly.",
+            "schema": {
+              "$ref": "#/definitions/KeyValue"
+            }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed",
+            "schema": {
+              "$ref": "#/definitions/Error"
+            }
+          }
+        },
+        "x-ms-examples": {
+          "ConfigurationStores_ListKeyValue": {
+            "$ref": "./examples/ConfigurationStoresListKeyValue.json"
+          }
+        }
+      }
     }
   },
   "definitions": {
@@ -703,6 +754,73 @@
         }
       }
     },
+    "ListKeyValueParameters": {
+      "description": "The parameters used to list a configuration store key-value",
+      "required": [
+        "key"
+      ],
+      "type": "object",
+      "properties": {
+        "key": {
+          "description": "The key to retrieve.",
+          "type": "string"
+        },
+        "label": {
+          "description": "The label of the key.",
+          "type": "string"
+        }
+      }
+    },
+    "KeyValue": {
+      "description": "The result of a request to retrieve a key-value from the specified configuration store.",
+      "type": "object",
+      "properties": {
+        "key": {
+          "description": "The primary identifier of a key-value.\r\nThe key is used in unison with the label to uniquely identify a key-value.",
+          "type": "string",
+          "readOnly": true
+        },
+        "label": {
+          "description": "A value used to group key-values.\r\nThe label is used in unison with the key to uniquely identify a key-value.",
+          "type": "string",
+          "readOnly": true
+        },
+        "value": {
+          "description": "The value of the key-value.",
+          "type": "string",
+          "readOnly": true
+        },
+        "contentType": {
+          "description": "The content type of the key-value's value.\r\nProviding a proper content-type can enable transformations of values when they are retrieved by applications.",
+          "type": "string",
+          "readOnly": true
+        },
+        "eTag": {
+          "description": "An ETag indicating the state of a key-value within a configuration store.",
+          "type": "string",
+          "readOnly": true
+        },
+        "lastModified": {
+          "format": "date-time",
+          "description": "The last time a modifying operation was performed on the given key-value.",
+          "type": "string",
+          "readOnly": true
+        },
+        "locked": {
+          "description": "A value indicating whether the key-value is locked.\r\nA locked key-value may not be modified until it is unlocked.",
+          "type": "boolean",
+          "readOnly": true
+        },
+        "tags": {
+          "description": "A dictionary of tags that can help identify what a key-value may be applicable for.",
+          "type": "object",
+          "additionalProperties": {
+            "type": "string"
+          },
+          "readOnly": true
+        }
+      }
+    },
     "OperationDefinitionListResult": {
       "description": "The result of a request to list configuration store operations.",
       "type": "object",

specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2019-02-01-preview/examples/ConfigurationStoresListKeyValue.json

@@ -0,0 +1,29 @@
+{
+  "parameters": {
+    "subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
+    "resourceGroupName": "myResourceGroup",
+    "configStoreName": "fayeh",
+    "api-version": "2019-02-01-preview",
+    "listKeyValueParameters": {
+      "key": "MaxRequests",
+      "label": "dev"
+    }
+  },
+  "responses": {
+    "200": {
+      "body": {
+        "key": "MaxRequests",
+        "label": "dev",
+        "value": "100",
+        "contentType": "",
+        "eTag": "4f6dd610dd5e4deebc7fbaef685fb903",
+        "lastModified": "2017-12-05T02:41:26+00:00",
+        "locked": false,
+        "tags": {
+          "t1": "value1",
+          "t2": "value2"
+        }
+      }
+    }
+  }
+}

specification/appconfiguration/resource-manager/readme.md

@@ -91,6 +91,10 @@ directive:
     from: appconfiguration.json
     where: $.definitions.ApiKey.properties.readOnly
     reason: We did consider using an enum instead but found it to not be helpful.
+  - suppress: EnumInsteadOfBoolean
+    from: appconfiguration.json
+    where: $.definitions.KeyValue.properties.locked
+    reason: This is data plane level information proxied through the RP and cannot be changed.
 ```
 
 ## Multi-API/Profile support for AutoRest v3 generators 

specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json

@@ -246,7 +246,7 @@
     },
     "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/components/{resourceName}/purge": {
       "post": {
-        "description": "Purges data in an Application Insights component by a set of user-defined filters.",
+        "description": "Purges data in an Application Insights component by a set of user-defined filters.\n\nIn order to manage system resources, purge requests are throttled at 50 requests per hour. You should batch the execution of purge requests by sending a single command whose predicate includes all user identities that require purging. Use the in operator to specify multiple identities. You should run the query prior to using for a purge request to verify that the results are expected.",
         "operationId": "Components_Purge",
         "parameters": [
           {