Restructure project files #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the functions.html is loaded from webpack-dev-server using url https://localhost:3000/functions.html, it encounters errors. This appears to be because webpack-dev-server assumes a browser environment but custom functions are run directly using the JavaScript runtime. To work around this, use the dist folder for the custom function urls (page, metadata, and script): page: https://localhost:3000/dist/functions.html metadata: https://localhost:3000/dist/functions.json script: https://localhost:3000/dist/functions.js The taskpane which runs in the browser WebView control is still loaded using webpack-dev-server (https://localhost:3000/taskpane.html).
akrantz
commented
Dec 2, 2018
akrantz
commented
Dec 2, 2018
akrantz
pushed a commit
that referenced
this pull request
Dec 10, 2018
Added descriptions and a computation-intensive function
akrantz
added a commit
that referenced
this pull request
Feb 7, 2019
Update readme with link to JavaScript version of template
akrantz
added a commit
that referenced
this pull request
Feb 26, 2019
Converted TypeScript project to JavaScript
akrantz
added a commit
that referenced
this pull request
Mar 12, 2019
The following requirements will cause manifest validation to fail.
<Requirements>
<Sets DefaultMinVersion="1.1">
<Set Name="CustomFunctionsRuntime" MinVersion="1.1"/>
</Sets>
</Requirements>
c:\dev\git\Excel-Custom-Functions>npm run validate
> [email protected] validate c:\dev\git\Excel-Custom-Functions
> office-toolbox validate -m manifest.xml
Calling validation service. This might take a moment...
-------------------------------------
Validation: Failed
Error #1:
No supported Office products detected: There are no platforms which fulfil the requirements specified in the manifest. The most common reasons for this failure are issues in the Requirements section. Please review the manifest and try again. (link: undefined)
-------------------------------------
akrantz
added a commit
that referenced
this pull request
Mar 13, 2019
…eDev#124) The following requirements will cause manifest validation to fail. <Requirements> <Sets DefaultMinVersion="1.1"> <Set Name="CustomFunctionsRuntime" MinVersion="1.1"/> </Sets> </Requirements> c:\dev\git\Excel-Custom-Functions>npm run validate > [email protected] validate c:\dev\git\Excel-Custom-Functions > office-toolbox validate -m manifest.xml Calling validation service. This might take a moment... ------------------------------------- Validation: Failed Error #1: No supported Office products detected: There are no platforms which fulfil the requirements specified in the manifest. The most common reasons for this failure are issues in the Requirements section. Please review the manifest and try again. (link: undefined) -------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.