Repository navigation
検査: お話のスキップの検査の切り出しに、優待パスのお話の名前を足す - #4609
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013j3vPELgtDfDhHcSzW81PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main で
boot/event-replay-tap-check「スキップを押すと会話が閉じる」が落ちていた件。原因
#4597(レジェンドブリーダー優待パスのお話)で、お話のスキップ・最後まで見たときの処理に
LEGEND_BREEDER_PASS_STORY_IDとmarkLegendPassSeenが足された。この検査は再生画面の JSX だけを切り出して動かす作りで、切り出しの側にその名前の仮の定義が無かったため、スキップの途中で ReferenceError になり、会話が閉じないように見えていた。どちらか
検査が古いだけ。 本体では
17-release-changelog-login-missions.jsxに定義があり、ゲームのスキップは正しく動く。#4582(背景)・#4592(えるびん)は関係なし。直したこと
これまでほかのお話(HELL・MFバトルカードのはじまり・ハロウィン・ナイトの終章)について足してきたのと同じ形で、切り出しに仮の名前を足した。見る中身は弱めていない。画面は変わらないので更新履歴なし。
検査
run-checks --changed --base origin/main: 418本 OK / NG 0event-replay-tap-checkNG 0Generated by Claude Code