Repository navigation
Fix dev build: missing Akka.TestKit using in WireFormatSnapshotFormatterSpec - #8736
Merged
Aaronontheweb merged 1 commit intoOct 3, 2026
Merged
Conversation
…SnapshotFormatterSpec akkadotnet#8725 moved HexDumpFormatter into the shared test project (namespace Akka.TestKit); akkadotnet#8726 added a spec that uses it and merged after, so dev no longer compiles Akka.Serialization.V2.Tests.
Aaronontheweb
enabled auto-merge (squash)
October 2, 2026 22:57
Aaronontheweb
disabled auto-merge
October 3, 2026 00:11
Aaronontheweb
enabled auto-merge (squash)
October 3, 2026 00:11
Aaronontheweb
disabled auto-merge
October 3, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev doesn't compile
Akka.Serialization.V2.Testsright now:WireFormatSnapshotFormatterSpec(from #8726) usesHexDumpFormatter, which #8725 moved into the shared test project under theAkka.TestKitnamespace. The two PRs merged one after the other without a rebuild in between.Changes
using Akka.TestKit;toWireFormatSnapshotFormatterSpec.cs.Testing
Akka.Serialization.V2.Tests: 419 passed.Breaking changes
None.