Repository navigation
Serialization V2: fix docs and diagnostics drift; diagnose private nested message types - #8721
Merged
Aaronontheweb merged 1 commit intoOct 2, 2026
Conversation
…sted message types Docs no longer say an object collection element is unsupported (akkadotnet#8528). AKKASG007 and AKKASG015 cross-assembly text no longer says the generator cannot read a schema from a referenced assembly (akkadotnet#8534, akkadotnet#8537). New AKKASG045 reports an [AkkaSerializable] type that is private or protected, or nested in one, instead of CS0122 in generated code. Closes akkadotnet#8717
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8717. Part of #8675.
Changes
Docs text (
docs/articles/serialization/source-generated-serialization.md):objectcollection element is unsupported. It has worked since Treat object elements inside collections the same as an object field #8528. They now say only anobjectdictionary key is rejected (AKKASG003).objectis an envelope payload.Diagnostic text:
[AkkaSerializable]schema the generator can read in that assembly, and names the fixes: annotate it there, register a formatter, or declare the type in this assembly.New diagnostic (G-11):
[AkkaSerializable]type, or one nested inside such a type, used to fail with CS0122 in generated code and no AKKASG id. The generator now reports AKKASG045 at the type declaration and emits nothing for it. The message says to make the type and its containers internal or public.Tests (in
AkkaSerializerGeneratorDiagnosticsSpec): private nested type, public type inside a private type, internal and public nested types stay clean, and the new cross-assembly AKKASG007 text.Overlap with #8715
The generator PR for G-1 and G-3 (#8715) changes the supported-types table, the collections section and AKKASG007's text for
TimeSpanand small scalars. This PR does not touch the table or anyTimeSpanor scalar wording. The AKKASG007 change here is limited to the cross-assembly descriptor. The one-sentence edit in the "Not supported" paragraph sits just below the table, so a small textual merge may be needed.Breaking changes
None