Repository navigation
Hosting samples: class registry keys; document class keys for IRequiredActor under Native AOT - #8674
Merged
Aaronontheweb merged 1 commit intoSep 30, 2026
Conversation
…quiredActor under Native AOT
The samples' struct Echo{} keys work on the JIT but fail under Native AOT:
MS.DI can't close the open-generic IRequiredActor<> registration for a value type.
Aaronontheweb
enabled auto-merge (squash)
September 30, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hosting samples use
public struct Echo{}as theActorRegistry/IRequiredActor<TKey>key. That works on the JIT but fails under Native AOT.IRequiredActor<>is an open-generic DI registration, and Microsoft.Extensions.DependencyInjection can't close it withMakeGenericTypefor a value-type argument when dynamic code isn't available.public sealed class Echo{}.docs/articles/hosting/dependency-injection.mdgets a short note: use a class, not a struct, as the type key.No API change. We considered constraining
IRequiredActor<TActor>toclass, but that would break apps at compile time that copied the old samples, even non-AOT ones, so the docs route was chosen.