Skip to content

fix: honor TCP maximum frame size in pipes - #8659

Closed
tayfuryldz wants to merge 1 commit into
akkadotnet:devfrom
tayfuryldz:fix/8657-tcp-frame-segments
Closed

tayfuryldz wants to merge 1 commit into
akkadotnet:devfrom
tayfuryldz:fix/8657-tcp-frame-segments

Conversation

@tayfuryldz

Copy link
Copy Markdown

Fixes #8657.

Wires TcpSettings.MaxFrameSizeBytes into both transport pipes as minimumSegmentSize, preserving the existing input backpressure thresholds and output defaults. This restores the pre-pipeline setting semantics for larger configured frames without changing the default 4 KiB behavior. Also corrects the constructor/property wording to match the existing 1x validation.

Validation: git diff --check. Dependency restore/build was not run to avoid an unapproved dependency download; CI provides compilation/test execution.

Signed-off-by: tayfuryldz yildiztayfur668@gmail.com

Signed-off-by: tayfuryldz <yildiztayfur668@gmail.com>
@Aaronontheweb

Copy link
Copy Markdown
Member

Thanks for the PR. This has been superseded by #8663, which fixes #8657 the same way (MaxFrameSizeBytes as both pipes' minimumSegmentSize) and also adds a regression test and the akka.conf documentation. It's already merged into dev, so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Akka.IO: akka.io.tcp.maximum-frame-size stopped working in #8132; wire it to the pipe segment size

2 participants