Repository navigation
Revert "TestKit: put the DotNetty batching override under akka.remote, where the transport reads it (#8546)" - #8560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Reverts #8546 (
d88eec8da). The resulting tree is byte-identical to dev at78f5cdc9a, the commit before it, which had a full CI run.Why
#8546 was admin-merged without its own CI run. Once it landed, the TestKit override it fixed started reaching the DotNetty transport in every TestKit-based system, which:
RemoteConfigSpec.Remoting_should_contain_correct_BatchWriter_settings_in_ReferenceConfon dev, since that fact reads the running test system;batching.enabled = ondefault lost its end-to-end coverage without anyone deciding that.Because no run happened before the merge, the full effect on the remoting suites was never inspected. This revert restores the last fully tested state. The key move comes back as its own PR with the
RemoteConfigSpecadjustment folded in and runs CI the normal way.Test-only change. No ledger entry.