Repository navigation
chore: remove global:: qualifiers from hand-written code - #8387
Merged
Aaronontheweb merged 1 commit intoJul 16, 2026
Merged
Conversation
global:: belongs in generated code (protobuf .g.cs, source-generator emission), where output must survive arbitrary user namespaces. In hand-written source it is noise -- replaced with plain names, usings, or a SysDebug alias where a genuine collision exists (ActorCell has a System property and Akka.Event has its own Debug type, so System.Diagnostics.Debug is unwritable in plain form there). 19 occurrences across 7 files; qualifier changes only, no behavior change. Affected specs pass: ActorPathSpec 41, AckedDeliverySpec 15, ArteryControlMessageSerializerSpec 32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
global::is the right tool in generated code (protobuf.g.cs, source-generator emission), where output must compile inside arbitrary user namespaces that can shadowSystem/Akka/MessagePack. In hand-written source it's noise — 19 occurrences across 7 files, now replaced with the shortest unambiguous form.Notable cases
ActorCell.FaultHandling.cs/ActorCell.DefaultMessages.cs: introducedusing SysDebug = System.Diagnostics.Debug;— insideActorCell, plainSystem.Diagnostics.Debugis unwritable (ActorCell.Systemproperty shadows the namespace) and unqualifiedDebugcollides withAkka.Event.Debug. The alias is the only clean spelling.usingdirectives or namespace-qualified forms.Verification
Akka,Akka.Cluster,Akka.Tests,Akka.Remote.Testsall build clean (0 warnings)global::remains in touched files; generated files untouchedQualifier/using changes only — no behavior change. (The Serialization.V2 branch got the same treatment separately in #8385.)