Repository navigation
Fix flaky cold-association timeout in MultiTransportAddressingSpec - #8362
Merged
Aaronontheweb merged 1 commit intoJul 10, 2026
Merged
Conversation
…rtAddressingSpec The spec's first ResolveOne per transport scheme raced a cold association (endpoint spin-up, AkkaProtocol handshake, first-use serialization JIT) against a hard 1-second Ask timeout that bypasses akka.test.timefactor, which intermittently times out on slow Windows CI agents. Nothing is lost while associating since EndpointWriter buffers sends until the handshake completes, so a single generous dilated wait removes the flake without retries or restructuring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Windows CI flake seen on #8360's validation run:
MultiTransportAddressingSpec.Should_Use_Second_Transport_For_Communicationfailing withActorNotFoundException ... AskTimeoutException: Timeout after 1.00 seconds.The spec's first
ResolveOneper transport scheme races a cold association — endpoint actor spin-up, the AkkaProtocol handshake, and first-use JIT of the serialization pipeline — against a hard 1-second Ask timeout.ResolveOneis a plainActorSelectionAPI, so that value also never routes throughakka.test.timefactorthe way the TestKitExpect*methods do. On a loaded 2-core Windows agent the cold path can eat the whole second; the in-memory TestTransport rules out socket issues, andEndpointWriterbuffers sends until the handshake completes, so nothing can be lost — the only failure mode is the timer itself.One-line fix (plus a comment): resolve with
Dilated(TimeSpan.FromSeconds(10)). Generous liveness bound, dilation restored, no retries or restructuring needed, all assertions unchanged. Passes 5/5 undertaskset -c 0,1(2-core emulation) locally.