fix: RejectOnType<TMessage> should use Rejection, not Failure - #8231
Merged
Merged
Conversation
The generic RejectOnType<TMessage>() was incorrectly calling FailOnType, causing the journal to crash instead of rejecting. Fixed to delegate to RejectOnType(Type) which uses the correct Rejection interceptor.
- RejectOnType<TMessage>() should reject matching types, not fail - Non-matching types should still pass through normally - This prevents the bug where RejectOnType<T>() was calling FailOnType Closes akkadotnet#8231
- PersistActor.WriteMessage.Data changed from string to object to support typed messages - RejectOnType<T> matching types are rejected (not failed) - RejectOnType<T> non-matching types pass through normally Fixes the bug where RejectOnType<TMessage>() was calling FailOnType instead of RejectOnType(Type)
Aaronontheweb
enabled auto-merge (squash)
June 3, 2026 05:42
Aaronontheweb
added a commit
that referenced
this pull request
Jun 3, 2026
…#8232) * fix: RejectOnType<TMessage> should use Rejection, not Failure The generic RejectOnType<TMessage>() was incorrectly calling FailOnType, causing the journal to crash instead of rejecting. Fixed to delegate to RejectOnType(Type) which uses the correct Rejection interceptor. * test: add regression tests for RejectOnType<T>() - RejectOnType<TMessage>() should reject matching types, not fail - Non-matching types should still pass through normally - This prevents the bug where RejectOnType<T>() was calling FailOnType Closes #8231 * test: add regression tests for RejectOnType<T>() - PersistActor.WriteMessage.Data changed from string to object to support typed messages - RejectOnType<T> matching types are rejected (not failed) - RejectOnType<T> non-matching types pass through normally Fixes the bug where RejectOnType<TMessage>() was calling FailOnType instead of RejectOnType(Type)
This was referenced Jun 12, 2026
Closed
Closed
Closed
This was referenced Jul 9, 2026
This was referenced Jul 23, 2026
This was referenced Aug 18, 2026
This was referenced Aug 27, 2026
Closed
Closed
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a copy-paste bug in
JournalWriteBehavior.cswhereRejectOnType<TMessage>()was callingFailOnType(typeof(TMessage))instead ofRejectOnType(typeof(TMessage)).This caused the test journal to fail/crash instead of rejecting messages of the specified type, defeating the purpose of the
RejectOnType<T>()API.Changes
RejectOnType<TMessage>()now delegates toRejectOnType(Type)which correctly usesJournalInterceptors.Rejection.InstanceImpact
This is a test kit fix only — it affects
Akka.Persistence.TestKitwhich is used in unit/integration tests. No production code changes.