Skip to content

Correct self-comparison in ShardCoordinator ResendShardHost handler #8050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 5 commits into from
Feb 25, 2026
Merged

Correct self-comparison in ShardCoordinator ResendShardHost handler #8050

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb1fd90
Correct self-comparison in ShardCoordinator ResendShardHost handler
MattKotsenas Feb 23, 2026
d7b8181
Merge branch 'dev' into refactor/region-equality
Aaronontheweb Feb 24, 2026
8219b8f
Merge branch 'dev' into refactor/region-equality
Aaronontheweb Feb 24, 2026
6e2d1ba
Merge branch 'dev' into refactor/region-equality
Aaronontheweb Feb 25, 2026
5870823
Merge branch 'dev' into refactor/region-equality
Aaronontheweb Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/contrib/cluster/Akka.Cluster.Sharding/ShardCoordinator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,7 +1792,7 @@ internal bool Active(object message)

case ResendShardHost m:
{
if (State.Shards.TryGetValue(m.Shard, out var region) && region.Equals(region))
if (State.Shards.TryGetValue(m.Shard, out var region) && region.Equals(m.Region))

@Aaronontheweb Aaronontheweb Feb 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woof - yeah this is a real bug alright. It's probably really rare in practice since the surface area for when this could cause a problem is in the middle of shard rebalancing during the timeout window, but you could potentially end up in a situation like #6973 - we know from affected users that the primary source of that issue was actually https://petabridge.com/blog/worst-dotnet-bug/ (ClusterSingleton split brain) but this is another route by which that same problem could be achieved. Nice catch.

SendHostShardMsg(m.Shard, region);
else
{
Expand Down
Loading