Fix logger initialization continuation race in LoggingBus#8006
Merged
Aaronontheweb merged 10 commits intoJan 25, 2026
Merged
Conversation
StartDefaultLoggers was only waiting for the Ask task (logger ACK), not the continuation that publishes "Logger started" message. This caused the continuation to run during test teardown, triggering EventFilter assertions. The fix returns the continuation task from AddLogger and uses TaskContinuationOptions.ExecuteSynchronously to ensure the continuation runs immediately when the Ask completes, before WaitAll returns.
Aaronontheweb
commented
Jan 22, 2026
Member
Author
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
I should point out that even though this fix touches core Akka, it's mostly just a problem for our test suite.
| }); | ||
| return (askTask, fullLoggerName); | ||
| }, TaskContinuationOptions.ExecuteSynchronously); | ||
| return (continuationTask, fullLoggerName); |
Member
Author
There was a problem hiding this comment.
Return the continuation task and have waiters wait on that, versus the original task itself.
Contributor
There was a problem hiding this comment.
Just noticed this now, but if askTask threw, the continuation would fail on var response = t.Result; and the logger would not be removed/unsubscribed. Maybe we need to check for t.IsFaulted too?
Arkatufus
reviewed
Jan 22, 2026
Contributor
Arkatufus
left a comment
Arkatufus
left a comment
There was a problem hiding this comment.
Comment not relayed to the actual fix
| }); | ||
| return (askTask, fullLoggerName); | ||
| }, TaskContinuationOptions.ExecuteSynchronously); | ||
| return (continuationTask, fullLoggerName); |
Contributor
There was a problem hiding this comment.
Just noticed this now, but if askTask threw, the continuation would fail on var response = t.Result; and the logger would not be removed/unsubscribed. Maybe we need to check for t.IsFaulted too?
Handle the case where the Ask operation fails with an exception, not just when it's cancelled. This ensures the logger is properly removed and unsubscribed if initialization throws an exception.
Aaronontheweb
commented
Jan 22, 2026
| } | ||
|
|
||
|
|
||
| // Ask operation failed with an exception |
Merged
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jan 26, 2026
…#8006) * Fix logger initialization continuation race in LoggingBus StartDefaultLoggers was only waiting for the Ask task (logger ACK), not the continuation that publishes "Logger started" message. This caused the continuation to run during test teardown, triggering EventFilter assertions. The fix returns the continuation task from AddLogger and uses TaskContinuationOptions.ExecuteSynchronously to ensure the continuation runs immediately when the Ask completes, before WaitAll returns. * Add IsFaulted check for logger initialization Handle the case where the Ask operation fails with an exception, not just when it's cancelled. This ensures the logger is properly removed and unsubscribed if initialization throws an exception.
Merged
Aaronontheweb
added a commit
that referenced
this pull request
Jan 26, 2026
* Fix logger initialization continuation race in LoggingBus StartDefaultLoggers was only waiting for the Ask task (logger ACK), not the continuation that publishes "Logger started" message. This caused the continuation to run during test teardown, triggering EventFilter assertions. The fix returns the continuation task from AddLogger and uses TaskContinuationOptions.ExecuteSynchronously to ensure the continuation runs immediately when the Ask completes, before WaitAll returns. * Add IsFaulted check for logger initialization Handle the case where the Ask operation fails with an exception, not just when it's cancelled. This ensures the logger is properly removed and unsubscribed if initialization throws an exception.
This was referenced Jan 27, 2026
This was referenced May 21, 2026
Open
Closed
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky EventFilterDebugTests where "Logger started" message was published during test teardown.
Problem
StartDefaultLoggerswas only waiting for the Ask task (logger ACK), not the continuation that publishes "Logger started" message. This caused the continuation to run during test teardown, triggering EventFilter assertions.Solution
The fix makes two changes to
AddLogger:Task.WaitAllwaits for the full initialization sequenceTaskContinuationOptions.ExecuteSynchronouslyto ensure the continuation runs immediately when the Ask completesChanges
src/core/Akka/Event/LoggingBus.cs: Return continuation task fromAddLogger()and addExecuteSynchronouslyoptionTest plan
EventFilterDebugTests.Messages_can_be_muted_from_now_on_with_usingpasses 10/10 runs