Skip to content

LogMessage GetProperties without FrozenDictionary #7968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Dec 17, 2025
Merged

LogMessage GetProperties without FrozenDictionary #7968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/core/Akka/Event/LogMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,15 @@ public IReadOnlyDictionary<string, object> GetProperties()
// Optimize: avoid ToArray() if Parameters() already returns IReadOnlyList
if (parameters is IReadOnlyList<object> readOnlyList)
{
_properties = CreatePropertyDictionary(PropertyNames, readOnlyList);

@Aaronontheweb Aaronontheweb Dec 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if (readOnlyList.Count == 0)
{
// Optimize: Skips parsing PropertyNames when empty Parameters()
_properties = EmptyDictionary;
}
else
{
_properties = CreatePropertyDictionary(PropertyNames, readOnlyList);
}
}
else
{
Expand Down Expand Up @@ -109,12 +117,7 @@ private static IReadOnlyDictionary<string, object> CreatePropertyDictionary(
dict[names[i]] = values[i];
}

#if NET8_0_OR_GREATER
// Use FrozenDictionary for optimal read performance on .NET 8+
return System.Collections.Frozen.FrozenDictionary.ToFrozenDictionary(dict);
#else
return dict;
#endif
}

private static readonly IReadOnlyDictionary<string, object> EmptyDictionary =
Expand Down
Loading