Repository navigation
Remove obsolete addorset from the API - #7622
Merged
Merged
Conversation
v1.4.33 Production Release
v1.4.34 Release
Akka.NET 1.4.35 release
Version 1.4.36 Release
v1.4.37 Release
Akka.NET v1.5 Production Deployment
kutal10
marked this pull request as draft
May 6, 2025 20:36
kutal10
marked this pull request as ready for review
May 6, 2025 20:37
Member
|
Thanks @kutal10 ! You might need to run the API approvals to get this to work: https://getakka.net/community/contributing/api-changes-compatibility.html |
Contributor
Author
@Aaronontheweb Yep followed the guide - PR now has the API txt files updated! |
# Conflicts: # src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt # src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt # src/core/Akka/Util/Internal/Extensions.cs
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Oct 1, 2026
Cover changes on dev since the v1.5 line diverged that landed before the ledger existed: net10.0-only targeting and ByteString removal (akkadotnet#8132), App.config HOCON loading removal (akkadotnet#7456), and the AddOrSet removal (akkadotnet#7622).
Aaronontheweb
added a commit
that referenced
this pull request
Oct 1, 2026
…8698 (#8700) * Audit BREAKING_CHANGES_V1.6.md against v1.5.71 and catch up through #8698 Restate the definition (binary / source / behavioral compatibility against the last stable v1.5 release), drop rows that are not breaking under it (Artery-only, DynamicTypeLoading-off-only, fixes, dev-only comparisons), fold the TargetInvocationException and trim-annotation rows into one row each, shorten the rest, mark every row Merged with its PR, and add the breaking changes from #8694 and #8698. * Add pre-ledger breaking changes to BREAKING_CHANGES_V1.6.md Cover changes on dev since the v1.5 line diverged that landed before the ledger existed: net10.0-only targeting and ByteString removal (#8132), App.config HOCON loading removal (#7456), and the AddOrSet removal (#7622). * Apply review feedback to BREAKING_CHANGES_V1.6.md Add rows for #8222 (Serializer overloads, ByteArraySerializer manifest), #8465 (explicit TLS hostname check), #8132 (TCP connects bypass akka.io.dns) and #7557 (object handler without predicate blocks later Receive calls). State net10.0-only once, folding in #8594 and the dependency bumps; fix the ByteString row's write types; narrow the #8698 row to module serializers; drop the .Internal AddOrSet row and say why in the preamble; shorten rows; use asterisk list markers. * Drop the #7557 ReceiveActor row from BREAKING_CHANGES_V1.6.md The Receive(typeof(object), Func<object, bool>) regression is being fixed in a separate PR instead of documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7463
Changes
Eliminates the unneeded
AddOrSetmethod API from1.6-AddOrReturnis also modified to account for this.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.