Skip to content

Mark IDaemonMsg with public interface marker #7596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 5 commits into from
Apr 18, 2025
Merged

Mark IDaemonMsg with public interface marker #7596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4f6521
Mark IDaemonMsg with public interface marker
Arkatufus Apr 11, 2025
7575d7c
Merge branch 'dev' into mark-IDaemonMsg-with-public-interface
Arkatufus Apr 11, 2025
fb10bbf
Update API Approval list
Arkatufus Apr 11, 2025
ac4b908
Merge branch 'mark-IDaemonMsg-with-public-interface' of github.com:Ar…
Arkatufus Apr 11, 2025
1f3451b
Merge branch 'dev' into mark-IDaemonMsg-with-public-interface
Aaronontheweb Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveRemote.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ namespace Akka.Remote
void Reset();
}
[Akka.Annotations.InternalApiAttribute()]
public interface IInternalRemotingMessage { }
[Akka.Annotations.InternalApiAttribute()]
public interface IRemoteActorRefProvider : Akka.Actor.IActorRefProvider
{
Akka.Actor.IInternalActorRef RemoteDaemon { get; }
Expand Down
2 changes: 2 additions & 0 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveRemote.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ namespace Akka.Remote
void Reset();
}
[Akka.Annotations.InternalApiAttribute()]
public interface IInternalRemotingMessage { }
[Akka.Annotations.InternalApiAttribute()]
public interface IRemoteActorRefProvider : Akka.Actor.IActorRefProvider
{
Akka.Actor.IInternalActorRef RemoteDaemon { get; }
Expand Down
10 changes: 9 additions & 1 deletion src/core/Akka.Remote/RemoteSystemDaemon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using Akka.Actor;
using Akka.Actor.Internal;
using Akka.Annotations;
using Akka.Dispatch.SysMsg;
using Akka.Event;
using Akka.Util;
Expand All @@ -22,8 +23,15 @@ namespace Akka.Remote
{
/// <summary>
/// INTERNAL API
/// Used to mark that a message is meant as a system call and should not be traced
/// </summary>
internal interface IDaemonMsg { }
[InternalApi]
public interface IInternalRemotingMessage { }

/// <summary>
/// INTERNAL API
/// </summary>
internal interface IDaemonMsg:IInternalRemotingMessage { }

/// <summary>
/// INTERNAL API
Expand Down