Feature/7582#7595
Merged
Merged
Conversation
Member
Author
|
Although the way this supervision strategy configuration method will work. Sadly we dont enforce some kind of Init callback for our snapshot or journal implementations. If we did, we could force all implementations to handle their setup in there, stuff like initializing connections and whatnot. Then if that fails we could provide out of the box detection for init failures and use custom exceptions to explicitly communicate initialization failure. But that would be a major breaking change for persistence plugin implementations. |
Arkatufus
approved these changes
May 7, 2025
Contributor
Arkatufus
left a comment
There was a problem hiding this comment.
LGTM, waiting for the CI/CD to go through
Member
|
Well done @Danthar - ty for your contribution |
This was referenced Oct 7, 2025
This was referenced Oct 20, 2025
This was referenced Nov 6, 2025
This was referenced Feb 20, 2026
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a facility to provide your own supervision strategy that is used to govern the journal and snapshot-store plugins
This is a WIP. I need to probably add a configuration Spec, and some crash behavior tests at the very least.
Fixes #7582
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksnot relevant
This PR's Benchmarks
not relevant