Repository navigation
reorganized dependencies into separate paths for .NET Standard, .NET 6/8+ - #7453
Merged
Merged
Conversation
Aaronontheweb
commented
Jan 9, 2025
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Member
Author
There was a problem hiding this comment.
Detailed my changes
| </ItemGroup> | ||
|
|
||
| <!-- Packages only for NetStandard --> | ||
| <ItemGroup Condition="'$(TargetFramework)' == '$(NetStandardLibVersion)'"> |
Member
Author
There was a problem hiding this comment.
- Don't need Polyfill on newer versions of .NET where
recordet al are natively supported - Don't need System.Reflection.Emit (built into BCL)
- Don't need System.Threading.Channels (built into BCL)
These are pre-requisites for supporting #6855 - which is going to require a System.Diagnostics.Activity dependency for netstandard2.0 only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
No material changes other than reducing the number of NuGet packages .NET 6+ users need to install.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):